Fix vm code base so that it can be built for --arch=simarm (no snapshot yet).

runtime/vm/assembler_arm.h

-// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ASSEMBLER_ARM_H_
 #define VM_ASSEMBLER_ARM_H_
 
 #ifndef VM_ASSEMBLER_H_
 #error Do not include assembler_arm.h directly; use assembler.h instead.
 #endif
 
 #include "platform/assert.h"
 #include "vm/constants_arm.h"
 
 namespace dart {
 
+class Operand : public ValueObject {
+ protected:
+  // Operand can be sub classed (e.g: Address).
+  Operand() { }
+
+ private:
+  DISALLOW_ALLOCATION();
+};
+
+
+class Address : public Operand {
+ public:
+  Address(Register base, int32_t disp) {
+    UNIMPLEMENTED();
+  }
+ private:
+  DISALLOW_ALLOCATION();
+};
+
+
+class FieldAddress : public Address {
+ public:
+  FieldAddress(Register base, int32_t disp)
+      : Address(base, disp - kHeapObjectTag) {}
+};
+
+
 class Label : public ValueObject {
  public:
   Label() : position_(0) { }
 
   ~Label() {
     // Assert if label is being destroyed with unresolved branches pending.
     ASSERT(!IsLinked());
   }
 
   // Returns the position for bound and linked labels. Cannot be used
   // for unused labels.
   int Position() const {
     ASSERT(!IsUnused());
     return IsBound() ? -position_ - kWordSize : position_ - kWordSize;
   }
 
   bool IsBound() const { return position_ < 0; }
   bool IsUnused() const { return position_ == 0; }
   bool IsLinked() const { return position_ > 0; }
+  bool HasNear() const { return false; }

[Ivan Posva, 2013/01/16 01:17:56]

Does ARM have near branches?

[regis, 2013/01/16 01:55:07]

No, but FlowGraphCompiler::~FlowGraphCompiler() is doing some architecture
dependent label checking. I duplicated it for each architecture and removed
HasNear() here.

+
 
  private:
   int position_;
 
   void Reinitialize() {
     position_ = 0;
   }
 
   void BindTo(int position) {
     ASSERT(!IsBound());
     position_ = -position - kWordSize;
     ASSERT(IsBound());
   }
 
   void LinkTo(int position) {
     ASSERT(!IsBound());
     position_ = position + kWordSize;
     ASSERT(IsLinked());
   }
 
   friend class Assembler;
   DISALLOW_COPY_AND_ASSIGN(Label);
 };
 
 
-class Assembler {
+class CPUFeatures : public AllStatic {
  public:
-  Assembler() { }
+  static void InitOnce() { }
+  static bool sse2_supported() { return false; }

[Ivan Posva, 2013/01/16 01:17:56]

This makes no sense for ARM, it needs to be taken out of the shared code.

[regis, 2013/01/16 01:55:07]

This is used by the flow_graph_optimizer, which I did not want to tackle in this
cl.

I have removed sse2_supported() and sse4_1_supported() here and added a TODO
with an #if defined in flow_graph_optimizer. 

+  static bool sse4_1_supported() { return false; }
+};
+
+
+class Assembler : public ValueObject {
+ public:
+  Assembler() { UNIMPLEMENTED(); }
   ~Assembler() { }
 
-  // Macros for High-level operations.
-  void AddConstant(Register reg, int value, Condition cond = AL) {
+  void PopRegister(Register r) {
+    UNIMPLEMENTED();
+  }
+
+  void Bind(Label* label) {
     UNIMPLEMENTED();
   }
 
   // Misc. functionality
   int CodeSize() const {
     UNIMPLEMENTED();
     return 0;
   }
   int prologue_offset() const {
     UNIMPLEMENTED();
@@ skipping 10 matching lines @@
   // Debugging and bringup support.
   void Stop(const char* message) { UNIMPLEMENTED(); }
   void Unimplemented(const char* message);
   void Untested(const char* message);
   void Unreachable(const char* message);
 
   static void InitializeMemoryWithBreakpoints(uword data, int length) {
     UNIMPLEMENTED();
   }
 
+  void Comment(const char* format, ...) PRINTF_ATTRIBUTE(2, 3) {
+    UNIMPLEMENTED();
+  }
+
+  const Code::Comments& GetCodeComments() const {
+    UNIMPLEMENTED();
+    return Code::Comments::New(0);
+  }
+
+  static const char* RegisterName(Register reg) {
+    UNIMPLEMENTED();
+    return NULL;
+  }
+
+  static const char* FpuRegisterName(DRegister reg) {
+    UNIMPLEMENTED();
+    return NULL;
+  }
+
  private:
   ZoneGrowableArray<int>* pointer_offsets_;
   DISALLOW_ALLOCATION();
   DISALLOW_COPY_AND_ASSIGN(Assembler);
 };
 
 }  // namespace dart
 
 #endif  // VM_ASSEMBLER_ARM_H_