Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1195583002: Measure the impact of a propsed change to createAttribute() (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Measure the impact of a propsed change to createAttribute() There is a proposal to lowercase name in HTML documents: https://bugzilla.mozilla.org/show_bug.cgi?id=1165851#c34 The counter in Document::createAttribute will catch any case where the change would be observable, providing an upper limit to the risk. The counter in Element::setAttributeNode is a reasonable proxy for the case which is most likely problematic, namely trying to set a camelCase Attr created by an HTML document on a non-HTML element, likely SVG, as suggested by Boris Zbarsky: https://bugzilla.mozilla.org/show_bug.cgi?id=1175031#c5 (The source of the Attr object need not be createAttribute, but extra bookkeeping to determine that would either increase sizeof(Attr) or require a new NodeFlags entry, so don't do that for now.) BUG=502301 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197549

Patch Set 1 #

Patch Set 2 : typo #

Patch Set 3 : check attr's document #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M Source/core/dom/Document.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195583002/1
5 years, 6 months ago (2015-06-19 17:03:26 UTC) #2
philipj_slow
PTAL and CQ? (UseCounter.h is prone to conflicts)
5 years, 6 months ago (2015-06-19 17:04:17 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/48140)
5 years, 6 months ago (2015-06-19 17:19:20 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195583002/20001
5 years, 6 months ago (2015-06-19 17:34:04 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-19 19:05:22 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195583002/40001
5 years, 6 months ago (2015-06-19 20:26:26 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-19 23:48:11 UTC) #14
dominicc (has gone to gerrit)
lgtm
5 years, 6 months ago (2015-06-22 01:07:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195583002/40001
5 years, 6 months ago (2015-06-22 01:07:24 UTC) #17
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 02:58:05 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197549

Powered by Google App Engine
This is Rietveld 408576698