pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart - Issue 1195573003: dart2js cps: Refactor and optimize string concatenations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

Issue 1195573003: dart2js cps: Refactor and optimize string concatenations. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Revert doc comment change Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

index 90c0b69577ac486b89976498474657cb73a978eb..47fedb7793795eb69812f94102a19b4c142375dc 100644

--- a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

@@ -385,11 +385,6 @@ class SubexpressionVisitor extends ExpressionVisitor<String> {

return "$keyword $callName($args)";

}

- String visitConcatenateStrings(ConcatenateStrings node) {

- String args = node.arguments.map(visitExpression).join(', ');

- return "concat [$args]";

- }

String visitLiteralList(LiteralList node) {

String values = node.values.map(visitExpression).join(', ');

return "list [$values]";