pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart - Issue 1195573003: dart2js cps: Refactor and optimize string concatenations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

Issue 1195573003: dart2js cps: Refactor and optimize string concatenations. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Revert doc comment change Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

diff --git a/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart b/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

index 6ac916253bb82579b3f95b90b9fbcd844ce5f9b0..eed6448075057df99c451595eb18a4e113df3063 100644

--- a/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

+++ b/pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart

@@ -557,11 +557,6 @@ class ParentVisitor extends RecursiveVisitor {

node.arguments.forEach((Reference ref) => ref.parent = node);

}

- processConcatenateStrings(ConcatenateStrings node) {

- node.continuation.parent = node;

- node.arguments.forEach((Reference ref) => ref.parent = node);

- }

processBranch(Branch node) {

node.condition.parent = node;

node.trueContinuation.parent = node;