Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart

Issue 1195573003: dart2js cps: Refactor and optimize string concatenations. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Remove renegade linebreak Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
index fee1dd7adcb33d52b63659533e63a44f2bcabc96..7676806fe359b6758e99090486b68542584b8362 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart
@@ -376,11 +376,6 @@ class SubexpressionVisitor extends ExpressionVisitor<String> {
return "$keyword $callName($args)";
}
- String visitConcatenateStrings(ConcatenateStrings node) {
- String args = node.arguments.map(visitExpression).join(', ');
- return "concat [$args]";
- }
-
String visitLiteralList(LiteralList node) {
String values = node.values.map(visitExpression).join(', ');
return "list [$values]";

Powered by Google App Engine
This is Rietveld 408576698