Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 1195563003: Reland [turbofan] Disable select matching due to bug manifesting on arm. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland [turbofan] Disable select matching due to bug manifesting on arm. (patchset #2 id:40001 of https://codereview.chromium.org/1176403005/) Reason for revert: This causes timeouts in Massive on chromebooks. Original issue's description: > Revert of [turbofan] Disable select matching due to bug manifesting on arm. (patchset #1 id:1 of https://codereview.chromium.org/1077613002/) > > Reason for revert: > [Sheriff] Checking if this still fails and if yes persists info about failures. > > Original issue's description: > > [turbofan] Disable select matching due to bug manifesting on arm. > > > > R=machenbach@chromium.org > > BUG= > > > > Committed: https://crrev.com/6e5d805718195c4b5ac64cd540379cecf10b8f5c > > Cr-Commit-Position: refs/heads/master@{#27702} > > TBR=bmeurer@chromium.org > > Committed: https://crrev.com/7c36a7d91d8706b29df07013085fbe3c8e93b0ed > Cr-Commit-Position: refs/heads/master@{#29103} TBR=titzer@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/4a4ba797ae6828e760d947c42336b28dadf26ce4 Cr-Commit-Position: refs/heads/master@{#29107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Revert of Revert of [turbofan] Disable select matching due to bug manifesting on arm.
5 years, 6 months ago (2015-06-18 10:42:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195563003/1
5 years, 6 months ago (2015-06-18 10:42:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 10:43:04 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 10:43:23 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a4ba797ae6828e760d947c42336b28dadf26ce4
Cr-Commit-Position: refs/heads/master@{#29107}

Powered by Google App Engine
This is Rietveld 408576698