Update protocol.json to support explanations for securityStateChanged.

Update protocol.json to support explanations for securityStateChanged.

BUG=501533, 501551
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197393

[lgarron, 2015-06-17 21:55:20]

lgarron@chromium.org changed reviewers:
+ pfeldman@chromium.org

[lgarron, 2015-06-17 21:55:21]

This change will be followed up with UI changes in
https://codereview.chromium.org/1179353002 (draft).
The Chrome side will send these explanations with an update to SecurityHandler
(https://codereview.chromium.org/1181293003) , which in turn depends on
lower-level plumbing support (https://codereview.chromium.org/1181293003 ).

The new "explanations" list is optional, which means this change can be landed
safely as-is, followed by the SecurityHandler change.

[lgarron, 2015-06-18 01:50:26]

Patchset #2 (id:20001) has been deleted

[lgarron, 2015-06-18 01:52:41]

Patchset #2 (id:40001) has been deleted

[pfeldman, 2015-06-18 06:45:15]

Security.StateExplanation is specific enough, no need to repeat the prefix.

https://codereview.chromium.org/1195533002/diff/60001/Source/devtools/protoco...
File Source/devtools/protocol.json (right):

https://codereview.chromium.org/1195533002/diff/60001/Source/devtools/protoco...
Source/devtools/protocol.json:5015: "id": "SecurityStateExplanation",
StateExplanation

[pfeldman, 2015-06-18 06:45:23]

lgtm

[lgarron, 2015-06-18 17:32:50]

On 2015/06/18 at 06:45:23, pfeldman wrote:
> lgtm

Would you mind leaving it as SecurityStateExplanation instead of
StateExplanation? "StateExplanation" sounds a bit generic, and I have the
instinct that it might clash against future types in the domain.

[lgarron, 2015-06-18 19:14:50]

Per GChat, using Security.StateExplanation would:
- be more concise, and 
- match the style of some other protocol types,

but:
- SecurityAgent.StateExplanation and unprefixed "StateExplanation" sound a bit
weird to me, and
- Security[Agent].SecurityState already exists in the protocol.

As a follow-up, we should consider changing SecurityState[Explanation] to
State[Explanation]; Emily and I might want to have a powwow about whether to
keep the word "state".

[lgarron, 2015-06-18 19:14:55]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2015-06-18 19:15:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1195533002/60001

[commit-bot: I haz the power, 2015-06-18 20:39:12]

Committed patchset #2 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197393