Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: test/browser/runtime_tests.js

Issue 1195523002: Handle dynamic as bottom inside of function type reps (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Fix typo in comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | test/codegen/expect/BenchmarkBase.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/browser/runtime_tests.js
diff --git a/test/browser/runtime_tests.js b/test/browser/runtime_tests.js
index 9e4617b8255ac2807b54900cd325117f65688e94..09f20c325aa4f867f2f56d2b43a885f9d92c3bbb 100644
--- a/test/browser/runtime_tests.js
+++ b/test/browser/runtime_tests.js
@@ -409,11 +409,10 @@ suite('instanceOf', () => {
checkType(cls3, Foo);
checkType(bar3, functionType(B, [B, String]));
checkType(cls3, functionType(B, [B, String]));
- checkType(bar4, Foo, false);
- checkType(cls4, Foo, false);
- // TODO(vsm): Revisit. bar4 is (B, *) -> B. Perhaps it should be treated as top for a reified object.
- checkType(bar4, functionType(B, [B, String]), false);
- checkType(cls4, functionType(B, [B, String]), false);
+ checkType(bar4, Foo, true);
+ checkType(cls4, Foo, true);
+ checkType(bar4, functionType(B, [B, String]), true);
+ checkType(cls4, functionType(B, [B, String]), true);
checkType(bar5, Foo);
checkType(cls5, Foo);
checkType(bar5, functionType(B, [B, String]));
« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | test/codegen/expect/BenchmarkBase.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698