Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: lib/runtime/dart/isolate.js

Issue 1195523002: Handle dynamic as bottom inside of function type reps (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Fix typo in comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/core.js ('k') | lib/runtime/dart/js.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/isolate.js
diff --git a/lib/runtime/dart/isolate.js b/lib/runtime/dart/isolate.js
index 05d04f0e6af8f142d5fe706359f43e57e3879af8..2f176816c61ea377d212797f8e15d41cf6cc39fa 100644
--- a/lib/runtime/dart/isolate.js
+++ b/lib/runtime/dart/isolate.js
@@ -42,7 +42,7 @@ dart_library.library('dart/isolate', null, /* Imports */[
static spawn(entryPoint, message, opts) {
let paused = opts && 'paused' in opts ? opts.paused : false;
try {
- return dart.as(_isolate_helper.IsolateNatives.spawnFunction(entryPoint, message, paused).then(dart.fn(msg => new Isolate(dart.as(dart.dindex(msg, 1), SendPort), {pauseCapability: dart.as(dart.dindex(msg, 2), Capability), terminateCapability: dart.as(dart.dindex(msg, 3), Capability)}), Isolate, [core.Object])), async.Future$(Isolate));
+ return dart.as(_isolate_helper.IsolateNatives.spawnFunction(entryPoint, message, paused).then(dart.fn(msg => new Isolate(dart.as(dart.dindex(msg, 1), SendPort), {pauseCapability: dart.as(dart.dindex(msg, 2), Capability), terminateCapability: dart.as(dart.dindex(msg, 3), Capability)}), Isolate, [dart.dynamic])), async.Future$(Isolate));
} catch (e) {
let st = dart.stackTrace(e);
return async.Future$(Isolate).error(e, st);
@@ -64,7 +64,7 @@ dart_library.library('dart/isolate', null, /* Imports */[
} else if (args != null) {
throw new core.ArgumentError(`Args must be a list of Strings ${args}`);
}
- return dart.as(_isolate_helper.IsolateNatives.spawnUri(uri, args, message, paused).then(dart.fn(msg => new Isolate(dart.as(dart.dindex(msg, 1), SendPort), {pauseCapability: dart.as(dart.dindex(msg, 2), Capability), terminateCapability: dart.as(dart.dindex(msg, 3), Capability)}), Isolate, [core.Object])), async.Future$(Isolate));
+ return dart.as(_isolate_helper.IsolateNatives.spawnUri(uri, args, message, paused).then(dart.fn(msg => new Isolate(dart.as(dart.dindex(msg, 1), SendPort), {pauseCapability: dart.as(dart.dindex(msg, 2), Capability), terminateCapability: dart.as(dart.dindex(msg, 3), Capability)}), Isolate, [dart.dynamic])), async.Future$(Isolate));
} catch (e) {
let st = dart.stackTrace(e);
return async.Future$(Isolate).error(e, st);
@@ -146,7 +146,7 @@ dart_library.library('dart/isolate', null, /* Imports */[
let error = new RemoteError(errorDescription, stackDescription);
controller.addError(error, error.stackTrace);
};
- dart.fn(handleError, dart.void, [core.Object]);
+ dart.fn(handleError, dart.void, [dart.dynamic]);
controller = async.StreamController.broadcast({sync: true, onListen: dart.fn(() => {
port = RawReceivePort.new(handleError);
this.addErrorListener(port.sendPort);
@@ -173,8 +173,8 @@ dart_library.library('dart/isolate', null, /* Imports */[
removeErrorListener: [dart.void, [SendPort]]
}),
statics: () => ({
- spawn: [async.Future$(Isolate), [dart.functionType(dart.void, [dart.bottom]), core.Object], {paused: core.bool}],
- spawnUri: [async.Future$(Isolate), [core.Uri, core.List$(core.String), core.Object], {paused: core.bool, packageRoot: core.Uri}]
+ spawn: [async.Future$(Isolate), [dart.functionType(dart.void, [dart.dynamic]), dart.dynamic], {paused: core.bool}],
+ spawnUri: [async.Future$(Isolate), [core.Uri, core.List$(core.String), dart.dynamic], {paused: core.bool, packageRoot: core.Uri}]
}),
names: ['spawn', 'spawnUri']
});
@@ -211,7 +211,7 @@ dart_library.library('dart/isolate', null, /* Imports */[
}
}
dart.setSignature(RawReceivePort, {
- constructors: () => ({new: [RawReceivePort, [], [dart.functionType(dart.void, [dart.bottom])]]})
+ constructors: () => ({new: [RawReceivePort, [], [dart.functionType(dart.void, [dart.dynamic])]]})
});
class _IsolateUnhandledException extends core.Object {
_IsolateUnhandledException(message, source, stackTrace) {
@@ -225,7 +225,7 @@ dart_library.library('dart/isolate', null, /* Imports */[
}
_IsolateUnhandledException[dart.implements] = () => [core.Exception];
dart.setSignature(_IsolateUnhandledException, {
- constructors: () => ({_IsolateUnhandledException: [_IsolateUnhandledException, [core.Object, core.Object, core.StackTrace]]})
+ constructors: () => ({_IsolateUnhandledException: [_IsolateUnhandledException, [dart.dynamic, dart.dynamic, core.StackTrace]]})
});
let _description = Symbol('_description');
class RemoteError extends core.Object {
« no previous file with comments | « lib/runtime/dart/core.js ('k') | lib/runtime/dart/js.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698