Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/runtime/dart/_native_typed_data.js

Issue 1195523002: Handle dynamic as bottom inside of function type reps (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Fix typo in comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/_js_mirrors.js ('k') | lib/runtime/dart/async.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/_native_typed_data.js
diff --git a/lib/runtime/dart/_native_typed_data.js b/lib/runtime/dart/_native_typed_data.js
index 748de26a583f7ed086d2ca42759746dcc7891630..b8b48af65710625946a8e72e7dbc4615fa71da3b 100644
--- a/lib/runtime/dart/_native_typed_data.js
+++ b/lib/runtime/dart/_native_typed_data.js
@@ -519,7 +519,7 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
throw new core.ArgumentError(`Invalid length ${length}`);
return dart.as(length, core.int);
}
- dart.fn(_checkLength, core.int, [core.Object]);
+ dart.fn(_checkLength, core.int, [dart.dynamic]);
function _checkViewArguments(buffer, offsetInBytes, length) {
if (!dart.is(buffer, NativeByteBuffer)) {
throw new core.ArgumentError('Invalid view buffer');
@@ -531,7 +531,7 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
throw new core.ArgumentError(`Invalid view length ${length}`);
}
}
- dart.fn(_checkViewArguments, dart.void, [core.Object, core.Object, core.Object]);
+ dart.fn(_checkViewArguments, dart.void, [dart.dynamic, dart.dynamic, dart.dynamic]);
function _ensureNativeList(list) {
if (dart.is(list, _interceptors.JSIndexable))
return list;
@@ -699,9 +699,9 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
setUint8: [dart.void, [core.int, core.int]]
}),
statics: () => ({
- _create1: [NativeByteData, [core.Object]],
- _create2: [NativeByteData, [core.Object, core.Object]],
- _create3: [NativeByteData, [core.Object, core.Object, core.Object]]
+ _create1: [NativeByteData, [dart.dynamic]],
+ _create2: [NativeByteData, [dart.dynamic, dart.dynamic]],
+ _create3: [NativeByteData, [dart.dynamic, dart.dynamic, dart.dynamic]]
}),
names: ['_create1', '_create2', '_create3']
});
@@ -830,9 +830,9 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
}),
methods: () => ({sublist: [core.List$(core.double), [core.int], [core.int]]}),
statics: () => ({
- _create1: [NativeFloat32List, [core.Object]],
- _create2: [NativeFloat32List, [core.Object, core.Object]],
- _create3: [NativeFloat32List, [core.Object, core.Object, core.Object]]
+ _create1: [NativeFloat32List, [dart.dynamic]],
+ _create2: [NativeFloat32List, [dart.dynamic, dart.dynamic]],
+ _create3: [NativeFloat32List, [dart.dynamic, dart.dynamic, dart.dynamic]]
}),
names: ['_create1', '_create2', '_create3']
});
@@ -878,9 +878,9 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
}),
methods: () => ({sublist: [core.List$(core.double), [core.int], [core.int]]}),
statics: () => ({
- _create1: [NativeFloat64List, [core.Object]],
- _create2: [NativeFloat64List, [core.Object, core.Object]],
- _create3: [NativeFloat64List, [core.Object, core.Object, core.Object]]
+ _create1: [NativeFloat64List, [dart.dynamic]],
+ _create2: [NativeFloat64List, [dart.dynamic, dart.dynamic]],
+ _create3: [NativeFloat64List, [dart.dynamic, dart.dynamic, dart.dynamic]]
}),
names: ['_create1', '_create2', '_create3']
});
@@ -933,9 +933,9 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
sublist: [core.List$(core.int), [core.int], [core.int]]
}),
statics: () => ({
- _create1: [NativeInt16List, [core.Object]],
- _create2: [NativeInt16List, [core.Object, core.Object]],
- _create3: [NativeInt16List, [core.Object, core.Object, core.Object]]
+ _create1: [NativeInt16List, [dart.dynamic]],
+ _create2: [NativeInt16List, [dart.dynamic, dart.dynamic]],
+ _create3: [NativeInt16List, [dart.dynamic, dart.dynamic, dart.dynamic]]
}),
names: ['_create1', '_create2', '_create3']
});
@@ -988,9 +988,9 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
sublist: [core.List$(core.int), [core.int], [core.int]]
}),
statics: () => ({
- _create1: [NativeInt32List, [core.Object]],
- _create2: [NativeInt32List, [core.Object, core.Object]],
- _create3: [NativeInt32List, [core.Object, core.Object, core.Object]]
+ _create1: [NativeInt32List, [dart.dynamic]],
+ _create2: [NativeInt32List, [dart.dynamic, dart.dynamic]],
+ _create3: [NativeInt32List, [dart.dynamic, dart.dynamic, dart.dynamic]]
}),
names: ['_create1', '_create2', '_create3']
});
@@ -1043,9 +1043,9 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
sublist: [core.List$(core.int), [core.int], [core.int]]
}),
statics: () => ({
- _create1: [NativeInt8List, [core.Object]],
- _create2: [NativeInt8List, [core.Object, core.Object]],
- _create3: [typed_data.Int8List, [core.Object, core.Object, core.Object]]
+ _create1: [NativeInt8List, [dart.dynamic]],
+ _create2: [NativeInt8List, [dart.dynamic, dart.dynamic]],
+ _create3: [typed_data.Int8List, [dart.dynamic, dart.dynamic, dart.dynamic]]
}),
names: ['_create1', '_create2', '_create3']
});
@@ -1098,9 +1098,9 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
sublist: [core.List$(core.int), [core.int], [core.int]]
}),
statics: () => ({
- _create1: [NativeUint16List, [core.Object]],
- _create2: [NativeUint16List, [core.Object, core.Object]],
- _create3: [NativeUint16List, [core.Object, core.Object, core.Object]]
+ _create1: [NativeUint16List, [dart.dynamic]],
+ _create2: [NativeUint16List, [dart.dynamic, dart.dynamic]],
+ _create3: [NativeUint16List, [dart.dynamic, dart.dynamic, dart.dynamic]]
}),
names: ['_create1', '_create2', '_create3']
});
@@ -1153,9 +1153,9 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
sublist: [core.List$(core.int), [core.int], [core.int]]
}),
statics: () => ({
- _create1: [NativeUint32List, [core.Object]],
- _create2: [NativeUint32List, [core.Object, core.Object]],
- _create3: [NativeUint32List, [core.Object, core.Object, core.Object]]
+ _create1: [NativeUint32List, [dart.dynamic]],
+ _create2: [NativeUint32List, [dart.dynamic, dart.dynamic]],
+ _create3: [NativeUint32List, [dart.dynamic, dart.dynamic, dart.dynamic]]
}),
names: ['_create1', '_create2', '_create3']
});
@@ -1211,9 +1211,9 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
sublist: [core.List$(core.int), [core.int], [core.int]]
}),
statics: () => ({
- _create1: [NativeUint8ClampedList, [core.Object]],
- _create2: [NativeUint8ClampedList, [core.Object, core.Object]],
- _create3: [NativeUint8ClampedList, [core.Object, core.Object, core.Object]]
+ _create1: [NativeUint8ClampedList, [dart.dynamic]],
+ _create2: [NativeUint8ClampedList, [dart.dynamic, dart.dynamic]],
+ _create3: [NativeUint8ClampedList, [dart.dynamic, dart.dynamic, dart.dynamic]]
}),
names: ['_create1', '_create2', '_create3']
});
@@ -1269,9 +1269,9 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
sublist: [core.List$(core.int), [core.int], [core.int]]
}),
statics: () => ({
- _create1: [NativeUint8List, [core.Object]],
- _create2: [NativeUint8List, [core.Object, core.Object]],
- _create3: [NativeUint8List, [core.Object, core.Object, core.Object]]
+ _create1: [NativeUint8List, [dart.dynamic]],
+ _create2: [NativeUint8List, [dart.dynamic, dart.dynamic]],
+ _create3: [NativeUint8List, [dart.dynamic, dart.dynamic, dart.dynamic]]
}),
names: ['_create1', '_create2', '_create3']
});
@@ -1573,7 +1573,7 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
reciprocal: [typed_data.Float32x4, []],
reciprocalSqrt: [typed_data.Float32x4, []]
}),
- statics: () => ({_truncate: [core.Object, [core.Object]]}),
+ statics: () => ({_truncate: [dart.dynamic, [dart.dynamic]]}),
names: ['_truncate']
});
dart.defineLazyProperties(NativeFloat32x4, {
@@ -1787,7 +1787,7 @@ dart_library.library('dart/_native_typed_data', null, /* Imports */[
withFlagW: [typed_data.Int32x4, [core.bool]],
select: [typed_data.Float32x4, [typed_data.Float32x4, typed_data.Float32x4]]
}),
- statics: () => ({_truncate: [core.Object, [core.Object]]}),
+ statics: () => ({_truncate: [dart.dynamic, [dart.dynamic]]}),
names: ['_truncate']
});
dart.defineLazyProperties(NativeInt32x4, {
« no previous file with comments | « lib/runtime/dart/_js_mirrors.js ('k') | lib/runtime/dart/async.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698