Handle dynamic as bottom inside of function type reps

lib/runtime/_classes.js

Index: lib/runtime/_classes.js
diff --git a/lib/runtime/_classes.js b/lib/runtime/_classes.js
index 6f2fbd8d74758a804d58f48f34e45fd3da347d89..11205d632cf48a91514bacabc35284bea142ca41 100644
--- a/lib/runtime/_classes.js
+++ b/lib/runtime/_classes.js
@@ -118,10 +118,6 @@ dart_library.library('dart_runtime/_classes', null, /* Imports */[
         throwError('requires ' + length + ' or 0 type arguments');
       }
       let args = slice.call(arguments);
-      // TODO(leafp): This should really be core.Object for
-      // consistency, but Object is not attached to core
-      // until the entire core library has been processed,
-      // which is too late.
       while (args.length < length) args.push(types.dynamic);
 
       let value = resultMap;
@@ -175,7 +171,7 @@ dart_library.library('dart_runtime/_classes', null, /* Imports */[
     if (sigObj === void 0) return void 0;
     let parts = sigObj[name];
     if (parts === void 0) return void 0;
-    return types.functionType.apply(null, parts);
+    return types.definiteFunctionType.apply(null, parts);

[vsm, 2015/06/17 23:14:38]

Should these really be definite for instance methods?  See #129.

[Leaf, 2015/06/17 23:44:37]

I don't think this affects #129.  #129 has to do with what static type we use,
and how we generate code (e.g. either a dinvoke or not).  So in the checker, we
need to decide whether to expose methods as having a fuzzy type or a definite
type.  Currently I believe that we expose them as fuzzy, which is why the
override in #129 is allowed (and why a dinvoke is needed).

This on the other hand has to do with what runtime type we assign.  It is always
the case that definiteFunctionType(args) <: functionType(args), and so any
runtime type checks that used to succeed will still succeed (the runtime type
only appears on the left hand side of subtype checks).  Finally, it is always
safe to use a function at its definite type, since it is, by construction,
correct.

   }
 
   /// Get the type of a constructor from a class using the stored signature
@@ -189,7 +185,7 @@ dart_library.library('dart_runtime/_classes', null, /* Imports */[
     if (sigCtor === void 0) return void 0;
     let parts = sigCtor[name];
     if (parts === void 0) return void 0;
-    return types.functionType.apply(null, parts);
+    return types.definiteFunctionType.apply(null, parts);
   }
   exports.classGetConstructorType = _getConstructorType;
 
@@ -230,7 +226,7 @@ dart_library.library('dart_runtime/_classes', null, /* Imports */[
     for (let name of names) {
       rtti.tagMemoized(f[name], function() {
         let parts = f[_staticSig][name];
-        return types.functionType.apply(null, parts);
+        return types.definiteFunctionType.apply(null, parts);
       })
     }
   }