Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 1195513004: Change DontCheck under-invalidation checking mode to CacheSkipper (Closed)

Created:
4 years, 10 months ago by Xianzhu
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Change DontCheck under-invalidation checking mode to CacheSkipper We have some situation that under-invalidation is difficult to resolve. Previously we just set DontCheck under-invalidation checking mode when ENABLE(ASSERT) and ignore unmatched CacheDisplayItems. Now we have strict checking for unmatched CachedDisplayItems so we need to skip cache in all modes. Might be one of the reasons of bug 497614. BUG=497614 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197304

Patch Set 1 #

Patch Set 2 : Fix cache skipper initialization #

Patch Set 3 : Fix bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M Source/core/paint/BoxPainter.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/paint/LayoutObjectDrawingRecorder.h View 1 2 1 chunk +21 lines, -10 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItemList.cpp View 1 2 chunks +2 lines, -6 lines 0 comments Download
M Source/platform/graphics/paint/DrawingDisplayItem.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Xianzhu
4 years, 10 months ago (2015-06-17 23:24:34 UTC) #2
chrishtr
lgtm
4 years, 10 months ago (2015-06-17 23:27:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195513004/1
4 years, 10 months ago (2015-06-17 23:28:03 UTC) #5
Xianzhu
Just noticed a bug in LayoutObjectDrawingRecorder because we initialize cache skipper after DrawingRecorder so initialization ...
4 years, 10 months ago (2015-06-17 23:30:15 UTC) #7
Xianzhu
On 2015/06/17 23:30:15, Xianzhu wrote: > Just noticed a bug in LayoutObjectDrawingRecorder because we initialize ...
4 years, 10 months ago (2015-06-18 00:04:49 UTC) #8
chrishtr
lgtm
4 years, 10 months ago (2015-06-18 00:15:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195513004/40001
4 years, 10 months ago (2015-06-18 00:16:25 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 01:36:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197304

Powered by Google App Engine
This is Rietveld 408576698