Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: components/autofill/content/renderer/page_click_tracker.h

Issue 1195473005: Let PageClickTracker use onMouseDown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/page_click_tracker.h
diff --git a/components/autofill/content/renderer/page_click_tracker.h b/components/autofill/content/renderer/page_click_tracker.h
index 0c6585af0111e446abaffcc0be322c29a9852ba3..998de29febff08e651389ab8bed3302e7c605c4e 100644
--- a/components/autofill/content/renderer/page_click_tracker.h
+++ b/components/autofill/content/renderer/page_click_tracker.h
@@ -42,8 +42,7 @@ class PageClickTracker : public content::RenderFrameObserver {
// RenderViewObserver implementation.
void OnDestruct() override;
- void DidHandleMouseEvent(const blink::WebMouseEvent& event) override;
- void DidHandleGestureEvent(const blink::WebGestureEvent& event) override;
+ void OnMouseDown(const blink::WebNode& mouse_down_node) override;
void FocusChangeComplete() override;
private:
@@ -56,7 +55,7 @@ class PageClickTracker : public content::RenderFrameObserver {
// RenderViewObserver methods forwarded from Legacy. Should be
// merged into RenderFrameObserver.
- void DidHandleMouseEvent(const blink::WebMouseEvent& event);
+ void OnMouseDown(const blink::WebNode& mouse_down_node);
void DidHandleGestureEvent(const blink::WebGestureEvent& event);
Ilya Sherman 2015/06/18 21:58:16 nit: Please remove this. (It looks like you alrea
Yufeng Shen (Slow to review) 2015/06/19 00:08:32 Done.
void FocusChangeComplete();
void DoFocusChangeComplete();

Powered by Google App Engine
This is Rietveld 408576698