content/public/renderer/render_view_observer.h - Issue 1195473005: Let PageClickTracker use onMouseDown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/render_view_observer.h

Issue 1195473005: Let PageClickTracker use onMouseDown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change name onCLickInput to onMouseDown Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/renderer/render_view_observer.h

diff --git a/content/public/renderer/render_view_observer.h b/content/public/renderer/render_view_observer.h

index 6345aea53120c9754816f2710624d533d789a71a..b40a10ad165f615364773a8ec775874a2ffacd83 100644

--- a/content/public/renderer/render_view_observer.h

+++ b/content/public/renderer/render_view_observer.h

@@ -80,9 +80,10 @@ class CONTENT_EXPORT RenderViewObserver : public IPC::Listener,

virtual void DidUpdateLayout() {}

// These match the RenderView methods.

- virtual void DidHandleMouseEvent(const blink::WebMouseEvent& event) {}

virtual void DidHandleGestureEvent(const blink::WebGestureEvent& event) {}

+ virtual void onMouseDown(const blink::WebNode& mouse_down_node) {}

no sievers 2015/06/18 20:36:15 nit: OnMouseDown

Yufeng Shen (Slow to review) 2015/06/18 20:49:39 Done.

// These match incoming IPCs.

virtual void Navigate(const GURL& url) {}

virtual void ClosePage() {}