Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1195473003: cc: Set read lock fences required for YUV native video frames. (Closed)

Created:
5 years, 6 months ago by Daniele Castagna
Modified:
5 years, 6 months ago
Reviewers:
reveman
CC:
cc-bugs_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Set read lock fences required for YUV native video frames. BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/33aaa44d97878c9ba9e609c45b1215940515fe2d Cr-Commit-Position: refs/heads/master@{#334896}

Patch Set 1 #

Patch Set 2 : Remove flag in FrameResource. #

Total comments: 2

Patch Set 3 : Enable read lock fences for all the native planes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M cc/layers/video_layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/resource_provider.h View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/resources/resource_provider.cc View 2 chunks +10 lines, -1 line 0 comments Download
M cc/resources/video_resource_updater.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M cc/resources/video_resource_updater_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Daniele Castagna
5 years, 6 months ago (2015-06-17 16:18:23 UTC) #2
reveman
lgtm https://codereview.chromium.org/1195473003/diff/20001/cc/resources/video_resource_updater.cc File cc/resources/video_resource_updater.cc (right): https://codereview.chromium.org/1195473003/diff/20001/cc/resources/video_resource_updater.cc#newcode403 cc/resources/video_resource_updater.cc:403: external_resources.read_lock_fences_enabled = true; We'll need this for all ...
5 years, 6 months ago (2015-06-17 16:59:02 UTC) #3
Daniele Castagna
https://codereview.chromium.org/1195473003/diff/20001/cc/resources/video_resource_updater.cc File cc/resources/video_resource_updater.cc (right): https://codereview.chromium.org/1195473003/diff/20001/cc/resources/video_resource_updater.cc#newcode403 cc/resources/video_resource_updater.cc:403: external_resources.read_lock_fences_enabled = true; On 2015/06/17 at 16:59:02, reveman wrote: ...
5 years, 6 months ago (2015-06-17 17:02:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195473003/40001
5 years, 6 months ago (2015-06-17 17:03:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/76480)
5 years, 6 months ago (2015-06-17 18:32:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195473003/40001
5 years, 6 months ago (2015-06-17 19:24:22 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-17 20:06:58 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 20:07:48 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/33aaa44d97878c9ba9e609c45b1215940515fe2d
Cr-Commit-Position: refs/heads/master@{#334896}

Powered by Google App Engine
This is Rietveld 408576698