Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1195453005: [Fetch] Omit console error messages for cancellation, timeout, and non-BlinkInternal (Closed)

Created:
4 years, 10 months ago by hiroshige
Modified:
4 years, 10 months ago
Reviewers:
yhirano
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Fetch] Omit console error messages for cancellation, timeout, and non-BlinkInternal This CL aims to reduce duplicated console error messages. This CL also suppresses error messages when loading via WebDataConsumerHandle is cancelled. In such cases, didFail() is called by https://codereview.chromium.org/1186053004/ but we don't want to print error messages. The condition for printing error messages is based on the condition used by XHR (XMLHttpRequest::didFail()), except for we also output error messages for didFailRedirectCheck(). BUG=500258, 480746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197376

Patch Set 1 #

Patch Set 2 : Add a layout test. #

Total comments: 2

Patch Set 3 : Comment fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -3 lines) Patch
A LayoutTests/http/tests/fetch/chromium/error-messages.html View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/fetch/chromium/error-messages-expected.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
M Source/modules/fetch/FetchManager.cpp View 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
hiroshige
PTAL.
4 years, 10 months ago (2015-06-17 12:48:22 UTC) #2
hiroshige
If this code is fine I'll add layout tests under http/tests/fetch/chromium in this CL.
4 years, 10 months ago (2015-06-17 18:29:54 UTC) #3
yhirano
Looks good.
4 years, 10 months ago (2015-06-18 05:22:44 UTC) #4
hiroshige
Added a layout test.
4 years, 10 months ago (2015-06-18 08:15:24 UTC) #5
yhirano
https://codereview.chromium.org/1195453005/diff/20001/LayoutTests/http/tests/fetch/chromium/error-messages.html File LayoutTests/http/tests/fetch/chromium/error-messages.html (right): https://codereview.chromium.org/1195453005/diff/20001/LayoutTests/http/tests/fetch/chromium/error-messages.html#newcode29 LayoutTests/http/tests/fetch/chromium/error-messages.html:29: // outside modules/fetch, and thus we don't need messages ...
4 years, 10 months ago (2015-06-18 08:35:53 UTC) #6
hiroshige
https://codereview.chromium.org/1195453005/diff/20001/LayoutTests/http/tests/fetch/chromium/error-messages.html File LayoutTests/http/tests/fetch/chromium/error-messages.html (right): https://codereview.chromium.org/1195453005/diff/20001/LayoutTests/http/tests/fetch/chromium/error-messages.html#newcode29 LayoutTests/http/tests/fetch/chromium/error-messages.html:29: // outside modules/fetch, and thus we don't need messages ...
4 years, 10 months ago (2015-06-18 08:40:47 UTC) #7
yhirano
lgtm
4 years, 10 months ago (2015-06-18 10:57:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195453005/40001
4 years, 10 months ago (2015-06-18 11:08:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/67211)
4 years, 10 months ago (2015-06-18 13:31:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195453005/40001
4 years, 10 months ago (2015-06-18 16:19:53 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 17:17:36 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197376

Powered by Google App Engine
This is Rietveld 408576698