Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1195453003: Add missing null-check in OverscrollControllerAndroid::Animate() (Closed)

Created:
5 years, 6 months ago by jmanko
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing null-check in OverscrollControllerAndroid::Animate() Without it, there's a crash when running with disable-overscroll-edge-effect switch. BUG=501472 Committed: https://crrev.com/e3de7fc7dbb642ed034afa1c1fed70a748a60f35 Cr-Commit-Position: refs/heads/master@{#334897}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/android/overscroll_controller_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
jmanko
5 years, 6 months ago (2015-06-17 10:15:21 UTC) #2
Ted C
@jdduke is the best reviewer of this
5 years, 6 months ago (2015-06-17 16:54:59 UTC) #4
jdduke (slow)
lgtm, thanks. I went ahead and filed a bug so we can pick this to ...
5 years, 6 months ago (2015-06-17 19:10:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195453003/1
5 years, 6 months ago (2015-06-17 19:11:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 20:07:17 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e3de7fc7dbb642ed034afa1c1fed70a748a60f35 Cr-Commit-Position: refs/heads/master@{#334897}
5 years, 6 months ago (2015-06-17 20:09:11 UTC) #9
twinizzle
lgtm
5 years, 6 months ago (2015-06-17 23:09:34 UTC) #11
jmanko
5 years, 6 months ago (2015-06-18 09:38:54 UTC) #12
Message was sent while issue was closed.
On 2015/06/17 19:10:28, jdduke wrote:
> lgtm, thanks. I went ahead and filed a bug so we can pick this to M44.

I see it's been committed already :) great, thanks

Powered by Google App Engine
This is Rietveld 408576698