[turbofan] Remove another ineffective optimization from the ControlReducer.

test/cctest/compiler/test-osr.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/codegen.h"
 #include "src/compiler/all-nodes.h"
 #include "src/compiler/common-operator.h"
 #include "src/compiler/diamond.h"
 #include "src/compiler/graph.h"
 #include "src/compiler/js-graph.h"
@@ skipping 352 matching lines @@
 TEST(Deconstruct_osr_nested1) {
   OsrDeconstructorTester T(1);
 
   While outer(T, T.p0, false);
   While inner(T, T.p0, true);
   inner.Nest(outer);
 
   Node* outer_phi = outer.Phi(T.p0, T.p0, nullptr);
   outer.branch->ReplaceInput(0, outer_phi);
 
-  Node* osr_phi = inner.Phi(T.jsgraph.OneConstant(), T.osr_values[0],
-                            T.jsgraph.ZeroConstant());
+  Node* osr_phi = inner.Phi(T.jsgraph.TrueConstant(), T.osr_values[0],
+                            T.jsgraph.FalseConstant());
   inner.branch->ReplaceInput(0, osr_phi);
   outer_phi->ReplaceInput(1, osr_phi);
 
   Node* ret =
       T.graph.NewNode(T.common.Return(), outer_phi, T.start, outer.exit);
   Node* end = T.graph.NewNode(T.common.End(1), ret);
   T.graph.SetEnd(end);
 
   T.DeconstructOsr();
 
   // Check structure of deconstructed graph.
   // Check inner OSR loop is directly connected to start.
   CheckInputs(inner.loop, T.start, inner.if_true);
-  CheckInputs(osr_phi, T.osr_values[0], T.jsgraph.ZeroConstant(), inner.loop);
+  CheckInputs(osr_phi, T.osr_values[0], T.jsgraph.FalseConstant(), inner.loop);
 
   // Check control transfer to copy of outer loop.
   Node* new_outer_loop = FindSuccessor(inner.exit, IrOpcode::kLoop);
   Node* new_outer_phi = FindSuccessor(new_outer_loop, IrOpcode::kPhi);
   CHECK_NE(new_outer_loop, outer.loop);
   CHECK_NE(new_outer_phi, outer_phi);
 
   CheckInputs(new_outer_loop, inner.exit, new_outer_loop->InputAt(1));
 
   // Check structure of outer loop.
   Node* new_outer_branch = FindSuccessor(new_outer_loop, IrOpcode::kBranch);
   CHECK_NE(new_outer_branch, outer.branch);
   CheckInputs(new_outer_branch, new_outer_phi, new_outer_loop);
   Node* new_outer_exit = FindSuccessor(new_outer_branch, IrOpcode::kIfFalse);
   Node* new_outer_if_true = FindSuccessor(new_outer_branch, IrOpcode::kIfTrue);
 
   // Check structure of return.
   end = T.graph.end();
   Node* new_ret = end->InputAt(0);
   CHECK_EQ(IrOpcode::kReturn, new_ret->opcode());
   CheckInputs(new_ret, new_outer_phi, T.start, new_outer_exit);
 
   // Check structure of inner loop.
   Node* new_inner_loop = FindSuccessor(new_outer_if_true, IrOpcode::kLoop);
   Node* new_inner_phi = FindSuccessor(new_inner_loop, IrOpcode::kPhi);
 
-  CheckInputs(new_inner_phi, T.jsgraph.OneConstant(), T.jsgraph.ZeroConstant(),
-              new_inner_loop);
+  CheckInputs(new_inner_phi, T.jsgraph.TrueConstant(),
+              T.jsgraph.FalseConstant(), new_inner_loop);
   CheckInputs(new_outer_phi, osr_phi, new_inner_phi, new_outer_loop);
 }
 
 
 TEST(Deconstruct_osr_nested2) {
   OsrDeconstructorTester T(1);
 
   // Test multiple backedge outer loop.
   While outer(T, T.p0, false, 2);
   While inner(T, T.p0, true);
   inner.Nest(outer);
 
   Node* outer_phi = outer.Phi(T.p0, T.p0, T.p0);
   outer.branch->ReplaceInput(0, outer_phi);
 
-  Node* osr_phi = inner.Phi(T.jsgraph.OneConstant(), T.osr_values[0],
-                            T.jsgraph.ZeroConstant());
+  Node* osr_phi = inner.Phi(T.jsgraph.TrueConstant(), T.osr_values[0],
+                            T.jsgraph.FalseConstant());
   inner.branch->ReplaceInput(0, osr_phi);
   outer_phi->ReplaceInput(1, osr_phi);
-  outer_phi->ReplaceInput(2, T.jsgraph.ZeroConstant());
+  outer_phi->ReplaceInput(2, T.jsgraph.FalseConstant());
 
   Node* x_branch = T.graph.NewNode(T.common.Branch(), osr_phi, inner.exit);
   Node* x_true = T.graph.NewNode(T.common.IfTrue(), x_branch);
   Node* x_false = T.graph.NewNode(T.common.IfFalse(), x_branch);
 
   outer.loop->ReplaceInput(1, x_true);
   outer.loop->ReplaceInput(2, x_false);
 
   Node* ret =
       T.graph.NewNode(T.common.Return(), outer_phi, T.start, outer.exit);
   Node* end = T.graph.NewNode(T.common.End(1), ret);
   T.graph.SetEnd(end);
 
   T.DeconstructOsr();
 
   // Check structure of deconstructed graph.
   // Check inner OSR loop is directly connected to start.
   CheckInputs(inner.loop, T.start, inner.if_true);
-  CheckInputs(osr_phi, T.osr_values[0], T.jsgraph.ZeroConstant(), inner.loop);
+  CheckInputs(osr_phi, T.osr_values[0], T.jsgraph.FalseConstant(), inner.loop);
 
   // Check control transfer to copy of outer loop.
   Node* new_merge = FindSuccessor(x_true, IrOpcode::kMerge);
   CHECK_EQ(new_merge, FindSuccessor(x_false, IrOpcode::kMerge));
   CheckInputs(new_merge, x_true, x_false);
 
   Node* new_outer_loop = FindSuccessor(new_merge, IrOpcode::kLoop);
   Node* new_outer_phi = FindSuccessor(new_outer_loop, IrOpcode::kPhi);
   CHECK_NE(new_outer_loop, outer.loop);
   CHECK_NE(new_outer_phi, outer_phi);
 
   Node* new_entry_phi = FindSuccessor(new_merge, IrOpcode::kPhi);
-  CheckInputs(new_entry_phi, osr_phi, T.jsgraph.ZeroConstant(), new_merge);
+  CheckInputs(new_entry_phi, osr_phi, T.jsgraph.FalseConstant(), new_merge);
 
   CHECK_EQ(new_merge, new_outer_loop->InputAt(0));
 
   // Check structure of outer loop.
   Node* new_outer_branch = FindSuccessor(new_outer_loop, IrOpcode::kBranch);
   CHECK_NE(new_outer_branch, outer.branch);
   CheckInputs(new_outer_branch, new_outer_phi, new_outer_loop);
   Node* new_outer_exit = FindSuccessor(new_outer_branch, IrOpcode::kIfFalse);
   Node* new_outer_if_true = FindSuccessor(new_outer_branch, IrOpcode::kIfTrue);
 
   // Check structure of return.
   end = T.graph.end();
   Node* new_ret = end->InputAt(0);
   CHECK_EQ(IrOpcode::kReturn, new_ret->opcode());
   CheckInputs(new_ret, new_outer_phi, T.start, new_outer_exit);
 
   // Check structure of inner loop.
   Node* new_inner_loop = FindSuccessor(new_outer_if_true, IrOpcode::kLoop);
   Node* new_inner_phi = FindSuccessor(new_inner_loop, IrOpcode::kPhi);
 
-  CheckInputs(new_inner_phi, T.jsgraph.OneConstant(), T.jsgraph.ZeroConstant(),
-              new_inner_loop);
+  CheckInputs(new_inner_phi, T.jsgraph.TrueConstant(),
+              T.jsgraph.FalseConstant(), new_inner_loop);
   CheckInputs(new_outer_phi, new_entry_phi, new_inner_phi,
-              T.jsgraph.ZeroConstant(), new_outer_loop);
+              T.jsgraph.FalseConstant(), new_outer_loop);
 }
 
 
 Node* MakeCounter(JSGraph* jsgraph, Node* start, Node* loop) {
   int count = loop->InputCount();
   NodeVector tmp_inputs(jsgraph->graph()->zone());
   for (int i = 0; i < count; i++) {
     tmp_inputs.push_back(start);
   }
   tmp_inputs.push_back(loop);
@@ skipping 83 matching lines @@
 
   Node* new_loop0_phi = new_ret->InputAt(0);
   CHECK_EQ(IrOpcode::kPhi, new_loop0_phi->opcode());
   CHECK_EQ(new_loop0_loop, NodeProperties::GetControlInput(new_loop0_phi));
   CHECK_EQ(new_loop0_phi, FindSuccessor(new_loop0_loop, IrOpcode::kPhi));
 
   // Check that the return returns the phi from the OSR loop and control
   // depends on the copy of the outer loop0.
   CheckInputs(new_ret, new_loop0_phi, T.graph.start(), new_loop0_exit);
 }