Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1195443004: [turbofan] Remove another ineffective optimization from the ControlReducer. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove another ineffective optimization from the ControlReducer. The condition of a Branch or Select can never be a NumberConstant, because the resulting graph would be invalid, so we don't need to optimize this case. It can only ever be a tagged boolean or an untagged bit. Drive-by-fix: Test the interesting cases in the unit tests instead. R=jarin@chromium.org Committed: https://crrev.com/afc2fb26a151425fac7dd290108a1a91ff3836be Cr-Commit-Position: refs/heads/master@{#29089}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -47 lines) Patch
M src/compiler/control-reducer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-control-reducer.cc View 17 chunks +31 lines, -32 lines 0 comments Download
M test/cctest/compiler/test-osr.cc View 7 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-17 12:23:33 UTC) #1
Benedikt Meurer
Hey Jaro, Another obvious one. Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-17 12:23:58 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-17 12:33:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195443004/1
5 years, 6 months ago (2015-06-17 12:33:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 12:50:41 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 12:50:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afc2fb26a151425fac7dd290108a1a91ff3836be
Cr-Commit-Position: refs/heads/master@{#29089}

Powered by Google App Engine
This is Rietveld 408576698