Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Issue 1195423002: Use virtualenv to run commit_queue script (Closed)

Created:
5 years, 6 months ago by Sergiy Byelozyorov
Modified:
5 years, 1 month ago
Reviewers:
pgervais
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix path to virtualenv python #

Patch Set 3 : Rebase #

Patch Set 4 : Update after rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Update depot_tools before running commit_queue binary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -21 lines) Patch
M commit_queue View 1 2 3 4 5 1 chunk +5 lines, -1 line 0 comments Download
M commit_queue.bat View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M third_party/cq_client/cq_pb2.py View 1 chunk +5 lines, -14 lines 0 comments Download
M third_party/cq_client/validate_config.py View 1 2 3 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Sergiy Byelozyorov
5 years, 6 months ago (2015-06-22 17:28:51 UTC) #1
pgervais
On 2015/06/22 17:28:51, Sergiy Byelozyorov wrote: lgtm
5 years, 6 months ago (2015-06-24 00:56:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195423002/60001
5 years, 6 months ago (2015-06-25 19:05:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/95)
5 years, 6 months ago (2015-06-25 19:08:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195423002/120001
5 years, 6 months ago (2015-06-25 19:09:58 UTC) #12
Sergiy Byelozyorov
Committed patchset #6 (id:140001) manually as 295843 (presubmit successful).
5 years, 6 months ago (2015-06-25 19:15:39 UTC) #14
Sergiy Byelozyorov
A revert of this CL (patchset #6 id:140001) has been created in https://codereview.chromium.org/1412633006/ by sergiyb@chromium.org. ...
5 years, 1 month ago (2015-11-09 12:51:46 UTC) #15
Sergiy Byelozyorov
5 years, 1 month ago (2015-11-09 15:06:36 UTC) #16
Message was sent while issue was closed.
On 2015/11/09 12:51:46, Sergiy Byelozyorov wrote:
> A revert of this CL (patchset #6 id:140001) has been created in
> https://codereview.chromium.org/1412633006/ by mailto:sergiyb@chromium.org.
> 
> The reason for reverting is: virtualenv will be reverted because it breaks
> ChromiumOS build, see http://crbug.com/542922 and this CL depends on
virtualenv.

Actual revert is here https://codereview.chromium.org/1437483002/.

Powered by Google App Engine
This is Rietveld 408576698