core/src/fxge/android/fpf_skiamodule.cpp - Issue 1195363002: Cleanup: Do not check pointers before deleting them, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/android/fpf_skiamodule.cpp

Issue 1195363002: Cleanup: Do not check pointers before deleting them, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: nits Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fxge/android/fpf_skiamodule.cpp

diff --git a/core/src/fxge/android/fpf_skiamodule.cpp b/core/src/fxge/android/fpf_skiamodule.cpp

index 37bfd9cabbffa67d03371f7ef631913e7bd94abd..296073c4e23d3f90859f5fb59c98cca798fddc8a 100644

--- a/core/src/fxge/android/fpf_skiamodule.cpp

+++ b/core/src/fxge/android/fpf_skiamodule.cpp

@@ -22,10 +22,8 @@ CFPF_SkiaDeviceModule::~CFPF_SkiaDeviceModule()

}

void CFPF_SkiaDeviceModule::Destroy()

{

- if (gs_pPFModule) {

- delete (CFPF_SkiaDeviceModule*)gs_pPFModule;

- gs_pPFModule = NULL;

- }

+ delete (CFPF_SkiaDeviceModule*)gs_pPFModule;

+ gs_pPFModule = NULL;

}

IFPF_FontMgr* CFPF_SkiaDeviceModule::GetFontMgr()

{

« no previous file with comments | « core/src/fxge/agg/src/fx_agg_driver.cpp ('k') | core/src/fxge/apple/fx_mac_imp.cpp » ('j') | no next file with comments »