fpdfsdk/src/javascript/JS_Context.cpp - Issue 1195363002: Cleanup: Do not check pointers before deleting them, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/JS_Context.cpp

Issue 1195363002: Cleanup: Do not check pointers before deleting them, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/javascript/JS_Context.cpp

diff --git a/fpdfsdk/src/javascript/JS_Context.cpp b/fpdfsdk/src/javascript/JS_Context.cpp

index 924ab1ee19c9ea83895768b0eef0dcd031131b1a..aa6288172a8e38b8351611d48cd83e1f0880cf3b 100644

--- a/fpdfsdk/src/javascript/JS_Context.cpp

+++ b/fpdfsdk/src/javascript/JS_Context.cpp

@@ -24,11 +24,8 @@ CJS_Context::CJS_Context(CJS_Runtime* pRuntime) :

CJS_Context::~CJS_Context(void)

{

- if (m_pEventHandler)

- {

- delete m_pEventHandler;

- m_pEventHandler = NULL;

- }

+ delete m_pEventHandler;

+ m_pEventHandler = NULL;

Tom Sepez 2015/07/16 17:22:44 nit: pointless assignment?

Lei Zhang 2015/07/16 21:20:48 Done.

}

CPDFSDK_Document* CJS_Context::GetReaderDocument()

« fpdfsdk/src/fpdftext.cpp ('K') | « fpdfsdk/src/fpdftext.cpp ('k') | fpdfsdk/src/javascript/JS_Runtime.cpp » ('j') | no next file with comments »