fpdfsdk/src/formfiller/FFL_ComboBox.cpp - Issue 1195363002: Cleanup: Do not check pointers before deleting them, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/formfiller/FFL_ComboBox.cpp

Issue 1195363002: Cleanup: Do not check pointers before deleting them, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/formfiller/FFL_ComboBox.cpp

diff --git a/fpdfsdk/src/formfiller/FFL_ComboBox.cpp b/fpdfsdk/src/formfiller/FFL_ComboBox.cpp

index 5618e8a62b9817616a213327a3a9f0b65031c8e4..e4c8d4197521c9510c48ce07e94a90837eaaeaaf 100644

--- a/fpdfsdk/src/formfiller/FFL_ComboBox.cpp

+++ b/fpdfsdk/src/formfiller/FFL_ComboBox.cpp

@@ -23,11 +23,8 @@ CFFL_ComboBox::CFFL_ComboBox(CPDFDoc_Environment* pApp, CPDFSDK_Annot* pAnnot) :

CFFL_ComboBox::~CFFL_ComboBox()

{

- if (m_pFontMap)

- {

- delete m_pFontMap;

- m_pFontMap = NULL;

- }

+ delete m_pFontMap;

+ m_pFontMap = NULL;

Tom Sepez 2015/07/16 17:22:44 nit: pointless assignment?

Lei Zhang 2015/07/16 21:20:48 Done.

}

PWL_CREATEPARAM CFFL_ComboBox::GetCreateParam()

« core/src/fxge/apple/fx_mac_imp.cpp ('K') | « core/src/fxge/win32/fx_win32_dwrite.cpp ('k') | fpdfsdk/src/formfiller/FFL_ListBox.cpp » ('j') | fpdfsdk/src/formfiller/FFL_ListBox.cpp » ('J')