Cleanup: Do not check pointers before deleting them, part 2.

fpdfsdk/src/fpdftext.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../core/include/fpdfdoc/fpdf_doc.h"
 #include "../../core/include/fpdftext/fpdf_text.h"
 #include "../../public/fpdf_text.h"
 
 #ifdef _WIN32
 #include <tchar.h>
 #endif
 
         // jabdelmalek: commented out to build on Linux.  Not used.
         // extern HANDLE g_hModule;
 
 DLLEXPORT FPDF_TEXTPAGE STDCALL FPDFText_LoadPage(FPDF_PAGE page)
 {
         if (!page) return NULL;
         IPDF_TextPage* textpage=NULL;
         CPDF_ViewerPreferences viewRef(((CPDF_Page*)page)->m_pDocument);
         textpage=IPDF_TextPage::CreateTextPage((CPDF_Page*)page,viewRef.IsDirectionR2L());
         textpage->ParseTextPage();
         return textpage;
 }
 DLLEXPORT void STDCALL FPDFText_ClosePage(FPDF_TEXTPAGE text_page)
 {
-        if (text_page){
-                IPDF_TextPage* textpage=(IPDF_TextPage*)text_page;
-                delete textpage;
-                text_page=NULL;
-        }
+    delete (IPDF_TextPage*)text_page;
+    text_page = NULL;

[Tom Sepez, 2015/07/16 17:22:44]

nit: pointless assignment, not passed as ref.

[Lei Zhang, 2015/07/16 21:20:48]

Done.

 }
 DLLEXPORT int STDCALL FPDFText_CountChars(FPDF_TEXTPAGE text_page)
 {
         if (!text_page) return  -1;
         IPDF_TextPage* textpage=(IPDF_TextPage*)text_page;
         return  textpage->CountChars();
 }
 DLLEXPORT unsigned int STDCALL FPDFText_GetUnicode(FPDF_TEXTPAGE text_page, int index)
 {
         if (!text_page) return -1;
@@ skipping 195 matching lines @@
         if (rect_index >= 0 && rect_index < rectArray.GetSize()) {
                 CFX_FloatRect rect=rectArray.GetAt(rect_index);
                 *left=rect.left;
                 *right=rect.right;
                 *top=rect.top;
                 *bottom=rect.bottom;
         }
 }
 DLLEXPORT void  STDCALL FPDFLink_CloseWebLinks(FPDF_PAGELINK link_page)
 {
-        if (!link_page) return;
-        IPDF_LinkExtract* pageLink=(IPDF_LinkExtract*)link_page;
-        delete pageLink;
-        pageLink =NULL;
+    delete (IPDF_LinkExtract*)link_page;
+    link_page = NULL;

[Tom Sepez, 2015/07/16 17:22:44]

nit: ditto.

[Lei Zhang, 2015/07/16 21:20:48]

Done.

 }