Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1195353002: Add aria-owns DumpAccessibilityTree test and make it pass. (Closed)

Created:
5 years, 6 months ago by dmazzoni
Modified:
5 years, 6 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, je_julie, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add aria-owns DumpAccessibilityTree test and make it pass. BUG=489590 Committed: https://crrev.com/f3bcf1be3bd482be9bcf4db1793e94f42f7c2fef Cr-Commit-Position: refs/heads/master@{#335577}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 4

Patch Set 3 : Add link to test from code change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, --2 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-owns.html View 1 chunk +21 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-owns-actual-mac.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-owns-expected-android.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/data/accessibility/aria/aria-owns-expected-mac.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria/aria-owns-expected-win.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/accessibility/ax_tree_serializer.h View 1 2 3 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dmazzoni
5 years, 6 months ago (2015-06-22 19:44:16 UTC) #3
David Tseng
lgtm https://codereview.chromium.org/1195353002/diff/20001/content/test/data/accessibility/aria/aria-owns-expected-mac.txt File content/test/data/accessibility/aria/aria-owns-expected-mac.txt (right): https://codereview.chromium.org/1195353002/diff/20001/content/test/data/accessibility/aria/aria-owns-expected-mac.txt#newcode10 content/test/data/accessibility/aria/aria-owns-expected-mac.txt:10: ++++++++AXStaticText AXValue='Two' Curious, if an author wanted to ...
5 years, 6 months ago (2015-06-22 20:58:29 UTC) #4
dmazzoni
https://codereview.chromium.org/1195353002/diff/20001/content/test/data/accessibility/aria/aria-owns-expected-mac.txt File content/test/data/accessibility/aria/aria-owns-expected-mac.txt (right): https://codereview.chromium.org/1195353002/diff/20001/content/test/data/accessibility/aria/aria-owns-expected-mac.txt#newcode10 content/test/data/accessibility/aria/aria-owns-expected-mac.txt:10: ++++++++AXStaticText AXValue='Two' On 2015/06/22 20:58:29, David Tseng wrote: > ...
5 years, 6 months ago (2015-06-22 21:08:18 UTC) #5
dmazzoni
https://codereview.chromium.org/1195353002/diff/20001/ui/accessibility/ax_tree_serializer.h File ui/accessibility/ax_tree_serializer.h (right): https://codereview.chromium.org/1195353002/diff/20001/ui/accessibility/ax_tree_serializer.h#newcode336 ui/accessibility/ax_tree_serializer.h:336: // Work around flaky source trees where nodes don't ...
5 years, 6 months ago (2015-06-22 21:11:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195353002/40001
5 years, 6 months ago (2015-06-22 21:12:34 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-22 22:37:23 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 22:38:25 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f3bcf1be3bd482be9bcf4db1793e94f42f7c2fef
Cr-Commit-Position: refs/heads/master@{#335577}

Powered by Google App Engine
This is Rietveld 408576698