Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: Source/core/css/PropertySetCSSStyleDeclaration.h

Issue 119533003: Clear mutable inline style when it is empty. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed typo. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/PropertySetCSSStyleDeclaration.h
diff --git a/Source/core/css/PropertySetCSSStyleDeclaration.h b/Source/core/css/PropertySetCSSStyleDeclaration.h
index fcebaf4b34619ca8a7edae3ddf1c91f8ab4b16f2..e0cfc909b37872bae61c31b073f3a83f7230600c 100644
--- a/Source/core/css/PropertySetCSSStyleDeclaration.h
+++ b/Source/core/css/PropertySetCSSStyleDeclaration.h
@@ -46,6 +46,9 @@ public:
virtual void clearParentElement() { ASSERT_NOT_REACHED(); }
StyleSheetContents* contextStyleSheet() const;
+protected:
+ virtual PassRefPtr<CSSVariablesIterator> variablesIterator() const OVERRIDE;
+
private:
virtual CSSRule* parentRule() const OVERRIDE { return 0; };
virtual unsigned length() const OVERRIDE;
@@ -68,7 +71,6 @@ private:
virtual bool setVariableValue(const AtomicString& name, const String& value, ExceptionState&) OVERRIDE;
virtual bool removeVariable(const AtomicString& name) OVERRIDE;
virtual bool clearVariables(ExceptionState&) OVERRIDE;
- virtual PassRefPtr<CSSVariablesIterator> variablesIterator() const OVERRIDE;
virtual bool cssPropertyMatches(CSSPropertyID, const CSSValue*) const OVERRIDE;
virtual PassRefPtr<MutableStylePropertySet> copyProperties() const OVERRIDE;
@@ -136,6 +138,7 @@ public:
}
private:
+ PassRefPtr<CSSVariablesIterator> variablesIterator() const OVERRIDE;
eseidel 2013/12/23 21:22:43 Please mark it virtual as well as override (I know
chrishtr 2013/12/23 22:06:46 Done.
virtual MutableStylePropertySet* propertySet() const OVERRIDE;
virtual void ref() OVERRIDE;
virtual void deref() OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698