Clear mutable inline style when it is empty.

Source/core/css/InlineVariablesIterator.cpp

 /*
- * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
-#ifndef SourceAlpha_h
-#define SourceAlpha_h
+#include "config.h"
+#include "core/css/InlineVariablesIterator.h"
 
-#include "platform/graphics/filters/Filter.h"
-#include "platform/graphics/filters/FilterEffect.h"
+#include "RuntimeEnabledFeatures.h"
+#include "core/css/CSSVariableValue.h"
+#include "core/css/StylePropertySet.h"
+#include "core/dom/Element.h"
 
 namespace WebCore {
 
-class PLATFORM_EXPORT SourceAlpha : public FilterEffect {
-public:
-    static PassRefPtr<SourceAlpha> create(Filter*);
+PassRefPtr<InlineVariablesIterator> InlineVariablesIterator::create(Element* element)
+{
+    ASSERT(RuntimeEnabledFeatures::cssVariablesEnabled());
+    RefPtr<InlineVariablesIterator> iterator = adoptRef(new InlineVariablesIterator(element));
 
-    static const AtomicString& effectName();
+    const StylePropertySet* propertySet = element->inlineStyle();

[eseidel, 2013/12/23 21:22:43]

Shouldn't this be in the constructor itself instead of the ::create wrapper?

[chrishtr, 2013/12/23 22:06:46]

Good point. I was following the existing structure without thinking much about
it. 

+    if (propertySet) {
+        AbstractVariablesIterator::initRemainingNames(propertySet, iterator.get());
+    }
+    return iterator.release();
+}
 
-    virtual void determineAbsolutePaintRect();
 
-    virtual FilterEffectType filterEffectType() const { return FilterEffectTypeSourceInput; }
-
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
-
-private:
-    SourceAlpha(Filter* filter)
-        : FilterEffect(filter)
-    {
-    }
-
-    virtual void applySoftware() OVERRIDE;
-};
+MutableStylePropertySet* InlineVariablesIterator::propertySet() const
+{
+    return m_element->ensureMutableInlineStyle();
+}
 
 } // namespace WebCore
-
-#endif // SourceAlpha_h