tools/json_schema_compiler/h_generator.py - Issue 11953121: Fix up how the JSON Schema compiler decides whether to include or forward

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/json_schema_compiler/h_generator.py

Issue 11953121: Fix up how the JSON Schema compiler decides whether to include or forward (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/json_schema_compiler/cpp_type_generator.py ('K') | « tools/json_schema_compiler/cpp_type_generator_test.py ('k') | tools/json_schema_compiler/schema_util.py » ('j') | tools/json_schema_compiler/schema_util.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/json_schema_compiler/h_generator.py

diff --git a/tools/json_schema_compiler/h_generator.py b/tools/json_schema_compiler/h_generator.py

index 0bc44b791620f00ac39919cbe1f866d91c4df1d9..43d14f8f7724c75436fd9ec3b4ca031111bb93a6 100644

--- a/tools/json_schema_compiler/h_generator.py

+++ b/tools/json_schema_compiler/h_generator.py

@@ -40,6 +40,7 @@ class HGenerator(object):

.Append('#include "base/memory/linked_ptr.h"')

.Append('#include "base/memory/scoped_ptr.h"')

.Append('#include "base/values.h"')

+ .Cblock(self._type_helper.GenerateIncludes())

.Append()

)

@@ -162,7 +163,7 @@ class HGenerator(object):

a typedef. This may not always be desired. If false,

primitive types are ignored.

"""

- classname = cpp_util.Classname(schema_util.StripSchemaNamespace(type_.name))

+ classname = cpp_util.Classname(schema_util.StripNamespace(type_.name))

c = Code()

if type_.functions: