Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 11953117: Merge 139659 (Closed)

Created:
7 years, 8 months ago by eae
Modified:
7 years, 8 months ago
Reviewers:
eae
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Merge 139659 > offsetWidth/height incorrect for images when zoomed > https://bugs.webkit.org/show_bug.cgi?id=106624 > > Source/WebCore: > > Reviewed by Levi Weintraub. > > offsetWidth and height are incorrect for images at certain zoom > levels due to flooring the values ones adjusted for zoom. > By rounding the value instead we avoid the problem and return > the right size. > > Test: fast/images/zoomed-offset-size.html > > * dom/Element.cpp: > (WebCore::Element::offsetWidth): > (WebCore::Element::offsetHeight): > (WebCore::Element::clientWidth): > (WebCore::Element::clientHeight): > Change to round (as opposed to floor) the zoom adjusted value. > > * rendering/RenderObject.h: > (WebCore::adjustLayoutUnitForAbsoluteZoom): > * rendering/style/RenderStyle.h: > (WebCore::adjustLayoutUnitForAbsoluteZoom): > Add LayoutUnit version of adjustForAbsoluteZoom to avoid float > conversion. > > LayoutTests: > > Reviewed by Levi Weintraub. > > Add test for offsetWidth/Height for zoomed image. > > * fast/images/zoomed-offset-size-expected.txt: Added. > * fast/images/zoomed-offset-size.html: Added. > TBR=eae@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, --2 lines) Patch
A + LayoutTests/fast/images/zoomed-offset-size.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/images/zoomed-offset-size-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/dom/Element.cpp View 4 chunks +16 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/RenderObject.h View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/WebCore/rendering/style/RenderStyle.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
eae
7 years, 8 months ago (2013-01-25 21:57:14 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698