Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Side by Side Diff: Source/WebCore/rendering/RenderBoxModelObject.cpp

Issue 11953096: Merge 140069 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/multicol/float-not-removed-crash-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 2806 matching lines...) Expand 10 before | Expand all | Expand 10 after
2817 toBoxModelObject->virtualChildren()->insertChildNode(toBoxModelObject, v irtualChildren()->removeChildNode(this, child, fullRemoveInsert), beforeChild, f ullRemoveInsert); 2817 toBoxModelObject->virtualChildren()->insertChildNode(toBoxModelObject, v irtualChildren()->removeChildNode(this, child, fullRemoveInsert), beforeChild, f ullRemoveInsert);
2818 } 2818 }
2819 2819
2820 void RenderBoxModelObject::moveChildrenTo(RenderBoxModelObject* toBoxModelObject , RenderObject* startChild, RenderObject* endChild, RenderObject* beforeChild, b ool fullRemoveInsert) 2820 void RenderBoxModelObject::moveChildrenTo(RenderBoxModelObject* toBoxModelObject , RenderObject* startChild, RenderObject* endChild, RenderObject* beforeChild, b ool fullRemoveInsert)
2821 { 2821 {
2822 // This condition is rarely hit since this function is usually called on 2822 // This condition is rarely hit since this function is usually called on
2823 // anonymous blocks which can no longer carry positioned objects (see r12076 1) 2823 // anonymous blocks which can no longer carry positioned objects (see r12076 1)
2824 // or when fullRemoveInsert is false. 2824 // or when fullRemoveInsert is false.
2825 if (fullRemoveInsert && isRenderBlock()) { 2825 if (fullRemoveInsert && isRenderBlock()) {
2826 RenderBlock* block = toRenderBlock(this); 2826 RenderBlock* block = toRenderBlock(this);
2827 if (block->hasPositionedObjects()) 2827 block->removePositionedObjects(0);
2828 block->removePositionedObjects(0); 2828 block->removeFloatingObjects();
2829 } 2829 }
2830 2830
2831 ASSERT(!beforeChild || toBoxModelObject == beforeChild->parent()); 2831 ASSERT(!beforeChild || toBoxModelObject == beforeChild->parent());
2832 for (RenderObject* child = startChild; child && child != endChild; ) { 2832 for (RenderObject* child = startChild; child && child != endChild; ) {
2833 // Save our next sibling as moveChildTo will clear it. 2833 // Save our next sibling as moveChildTo will clear it.
2834 RenderObject* nextSibling = child->nextSibling(); 2834 RenderObject* nextSibling = child->nextSibling();
2835 moveChildTo(toBoxModelObject, child, beforeChild, fullRemoveInsert); 2835 moveChildTo(toBoxModelObject, child, beforeChild, fullRemoveInsert);
2836 child = nextSibling; 2836 child = nextSibling;
2837 } 2837 }
2838 } 2838 }
2839 2839
2840 } // namespace WebCore 2840 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/fast/multicol/float-not-removed-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698