Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 11953044: Do not eliminate instructions that might throw. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (revision 17441)
+++ sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (working copy)
@@ -795,11 +795,8 @@
bool isDeadCode(HInstruction instruction) {
return !instruction.hasSideEffects()
+ && !instruction.canThrow()
&& instruction.usedBy.isEmpty
- // A dynamic getter that has no side effect can still throw
- // a NoSuchMethodError.
- && instruction is !HInvokeDynamicGetter
- && instruction is !HCheck
&& instruction is !HTypeGuard
&& instruction is !HParameterValue
&& instruction is !HLocalSet
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698