Issue 11953043: Implicit references are missing in heap profiles

Issue 11953043: Implicit references are missing in heap profiles (Closed)

Created:
7 years, 11 months ago by yurys

Modified:
7 years, 11 months ago

Reviewers:
alph-g, danno, Michael Starzinger, loislo

CC:
v8-dev, pfeldman

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Implicit references are missing in heap profiles Committed: https://code.google.com/p/v8/source/detail?r=13486

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -39 lines)			Patch
M	include/v8.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/heap.h	View	1	1 chunk	+2 lines, -7 lines	0 comments	Download
M	src/heap.cc	View	1	4 chunks	+27 lines, -25 lines	0 comments	Download
M	src/profile-generator.cc	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with one comment about the API change). https://codereview.chromium.org/11953043/diff/1/include/v8.h File include/v8.h (left): https://codereview.chromium.org/11953043/diff/1/include/v8.h#oldcode3219 include/v8.h:3219: static ...

7 years, 11 months ago (2013-01-23 17:39:07 UTC) #3

yurys

7 years, 11 months ago (2013-01-24 07:54:05 UTC) #4

https://codereview.chromium.org/11953043/diff/1/include/v8.h
File include/v8.h (left):

https://codereview.chromium.org/11953043/diff/1/include/v8.h#oldcode3219
include/v8.h:3219: static void SetGlobalGCPrologueCallback(GCCallback);
On 2013/01/23 17:39:07, Michael Starzinger wrote:
> I think it is better to mark this function as deprecated with the
V8_DEPRECATED
> macro instead of removing it right away. It might brake other embedders. We'll
> do the cleanup part with the next milestone.

Done.

https://codereview.chromium.org/11953043/diff/1/include/v8.h#oldcode3248
include/v8.h:3248: static void SetGlobalGCEpilogueCallback(GCCallback);
On 2013/01/23 17:39:07, Michael Starzinger wrote:
> Likewise.

Done.

Expand Messages | Collapse Messages