Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_page_handler.cc

Issue 11953021: Don't show the apps page on the NTP if the app launcher is installed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/new_tab_page_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc b/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc
index 3600116fffe86ae38eaad4e28dcf58a5983bfd39..bab99e3e77b07ad0f5c7659c47f05cc2b17ad4ef 100644
--- a/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc
+++ b/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc
@@ -8,6 +8,7 @@
#include "base/bind_helpers.h"
#include "base/memory/scoped_ptr.h"
#include "base/metrics/histogram.h"
+#include "chrome/browser/extensions/app_launcher.h"
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/sync/profile_sync_service.h"
@@ -73,6 +74,9 @@ void NewTabPageHandler::RegisterMessages() {
web_ui()->RegisterMessageCallback("logTimeToClick",
base::Bind(&NewTabPageHandler::HandleLogTimeToClick,
base::Unretained(this)));
+ web_ui()->RegisterMessageCallback("getShouldShowApps",
+ base::Bind(&NewTabPageHandler::HandleGetShouldShowApps,
+ base::Unretained(this)));
}
void NewTabPageHandler::HandleNotificationPromoClosed(const ListValue* args) {
@@ -167,6 +171,18 @@ void NewTabPageHandler::HandleLogTimeToClick(const ListValue* args) {
}
}
+void NewTabPageHandler::HandleGetShouldShowApps(const ListValue* args) {
+ extensions::UpdateIsAppLauncherEnabled(
+ base::Bind(&NewTabPageHandler::GotIsAppLauncherEnabled,
+ AsWeakPtr()));
+}
+
+void NewTabPageHandler::GotIsAppLauncherEnabled(bool is_enabled) {
+ base::FundamentalValue should_show_apps(!is_enabled);
+ web_ui()->CallJavascriptFunction("ntp.gotShouldShowApps", should_show_apps);
+}
+
Evan Stade 2013/01/25 00:11:02 ^H
+
// static
void NewTabPageHandler::RegisterUserPrefs(PrefServiceSyncable* prefs) {
// TODO(estade): should be syncable.

Powered by Google App Engine
This is Rietveld 408576698