Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 11953017: Revert 177842. This doesn't build in standalone webkit builds: (Closed)

Created:
7 years, 11 months ago by Nico
Modified:
7 years, 11 months ago
Reviewers:
Tom Finegan
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 177842. This doesn't build in standalone webkit builds: https://bugs.webkit.org/show_bug.cgi?id=107468 It looks like the exact same problem happened when this landed the last time: https://bugs.webkit.org/show_bug.cgi?id=105813 Please make sure this issue is fixed before you reland. The CL also likely regressed binary size by 0.25MB: http://crbug.com/171143 > Add wrapper class to media for support of VP9 video, and add a command line flag to enable the support. > > This initial version of the wrapper provides support for decoding VP9 video in WebM container files, and is disabled by default. > > New flag added: --enable-vp9-playback > > TBR=brettw,scherkus,xhwang > BUG=166094 > TEST=VP9 video in WebM containers plays back in <video> elements when --enable-vp9-playback is specified on the command line. > > > Review URL: https://chromiumcodereview.appspot.com/12025030 TBR=tomfinegan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -497 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/media_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/media_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M media/base/video_decoder_config.h View 2 chunks +2 lines, -6 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.cc View 3 chunks +3 lines, -22 lines 0 comments Download
D media/filters/vpx_video_decoder.h View 1 chunk +0 lines, -86 lines 0 comments Download
D media/filters/vpx_video_decoder.cc View 1 chunk +0 lines, -340 lines 0 comments Download
M media/media.gyp View 3 chunks +0 lines, -16 lines 0 comments Download
M webkit/media/filter_helpers.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
7 years, 11 months ago (2013-01-21 20:18:00 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698