Omnibox: Better Enforce Suggest Relevance Constraints in Keyword Mode

chrome/browser/autocomplete/search_provider.h

Index: chrome/browser/autocomplete/search_provider.h
diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h
index eb18fc2b27e967238cd4873398198f61a6f523ab..27560a95582a6515c5754597355f966f3cff30cb 100644
--- a/chrome/browser/autocomplete/search_provider.h
+++ b/chrome/browser/autocomplete/search_provider.h
@@ -251,9 +251,16 @@ class SearchProvider : public AutocompleteProvider,
 
   // Checks if suggested relevances violate certain expected constraints.
   // See UpdateMatches() for the use and explanation of these constraints.
-  bool IsTopMatchScoreTooLow() const;
-  bool IsTopMatchHighRankSearchForURL() const;
-  bool IsTopMatchNotInlinable() const;
+  // We pass in keyword_search_what_you_typed_relevance because the
+  // keyword verbatim result is not in |matches_| but can be important in
+  // testing these constraints if it's high-ranked than the best result

[Peter Kasting, 2013/01/21 20:22:57]

Nit: high-ranked -> ranked higher?

[Mark P, 2013/01/21 20:57:45]

Rephrased for precision and readability.

+  // in |matches_|.
+  bool IsTopMatchScoreTooLow(

[Peter Kasting, 2013/01/21 20:22:57]

Nit: We may want to comment what some of these test in the context of the larger
set of constraints we're aiming to enforce.  For example, "high rank search" is
a little unclear.

[Mark P, 2013/01/21 20:57:45]

These are explained in UpdateMatch().  (Note the comment above "See
UpdateMatches() for the use and explanation of these constraints.")

If the explanations there are no enough, please tell me.

+      int keyword_search_what_you_typed_relevance) const;
+  bool IsTopMatchHighRankSearchForURL(
+      int keyword_search_what_you_typed_relevance) const;
+  bool IsTopMatchNotInlinable(
+      int keyword_search_what_you_typed_relevance) const;
 
   // Updates |matches_| from the latest results; applies calculated relevances
   // if suggested relevances cause undesriable behavior. Updates |done_|.