Omnibox: Better Enforce Suggest Relevance Constraints in Keyword Mode

chrome/browser/autocomplete/search_provider.h

Index: chrome/browser/autocomplete/search_provider.h
diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h
index eb18fc2b27e967238cd4873398198f61a6f523ab..3d479e00303e3f58043877b2201877a104852e57 100644
--- a/chrome/browser/autocomplete/search_provider.h
+++ b/chrome/browser/autocomplete/search_provider.h
@@ -251,9 +251,16 @@ class SearchProvider : public AutocompleteProvider,
 
   // Checks if suggested relevances violate certain expected constraints.
   // See UpdateMatches() for the use and explanation of these constraints.
-  bool IsTopMatchScoreTooLow() const;
-  bool IsTopMatchHighRankSearchForURL() const;
-  bool IsTopMatchNotInlinable() const;
+  // We pass in keyword_search_what_you_typed_relevance because the

[msw, 2013/01/23 19:15:19]

nit: vertical bars, and i prefer 'verbatim' to 'search_what_you_typed'.

+  // keyword verbatim result is not in |matches_| but can be important in
+  // testing these constraints if has a higher relevance than the best

[msw, 2013/01/23 19:15:19]

nit: "if it"?

+  // result in |matches_|.
+  bool IsTopMatchScoreTooLow(
+      int keyword_search_what_you_typed_relevance) const;
+  bool IsTopMatchHighRankSearchForURL(
+      int keyword_search_what_you_typed_relevance) const;
+  bool IsTopMatchNotInlinable(
+      int keyword_search_what_you_typed_relevance) const;
 
   // Updates |matches_| from the latest results; applies calculated relevances
   // if suggested relevances cause undesriable behavior. Updates |done_|.