Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 11953014: Fix the regex flatting html to prevent misdetection (Closed)

Created:
7 years, 11 months ago by yoshiki
Modified:
7 years, 10 months ago
Reviewers:
Jói
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

Fix the regex flatting html to prevent misdetection In some case, the previous regex may mistake to detect a wrong part as a script/link tag. This patch fixes it.

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M grit/format/html_inline.py View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M grit/format/html_inline_unittest.py View 1 2 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yoshiki
Hi Joi, I'm working on optimizing JavaScript files. I found the flatting html feature sometimes ...
7 years, 11 months ago (2013-01-21 13:31:41 UTC) #1
Jói
LGTM with tiny nit. https://codereview.chromium.org/11953014/diff/6002/grit/format/html_inline_unittest.py File grit/format/html_inline_unittest.py (right): https://codereview.chromium.org/11953014/diff/6002/grit/format/html_inline_unittest.py#newcode85 grit/format/html_inline_unittest.py:85: Please add another blank line ...
7 years, 11 months ago (2013-01-21 15:17:01 UTC) #2
yoshiki
7 years, 11 months ago (2013-01-21 15:25:12 UTC) #3
Thanks for review!

But I don't know how to commit this patch. Should I just check the "Commit"
checkbox on this page?

https://codereview.chromium.org/11953014/diff/6002/grit/format/html_inline_un...
File grit/format/html_inline_unittest.py (right):

https://codereview.chromium.org/11953014/diff/6002/grit/format/html_inline_un...
grit/format/html_inline_unittest.py:85: 
On 2013/01/21 15:17:01, Jói wrote:
> Please add another blank line here. The rule is two blank lines between
> top-level elements, one between other elements (e.g. different methods of the
> same class).

Done.

Powered by Google App Engine
This is Rietveld 408576698