Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: content/browser/accessibility/browser_accessibility.cc

Issue 1195223006: Reports the position of the caret and current selection in content editables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased with master. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility.cc
diff --git a/content/browser/accessibility/browser_accessibility.cc b/content/browser/accessibility/browser_accessibility.cc
index f3cf3779f9f2909d7afcc9495d01950f45a0145f..2f75a85244706ed89b2a7150ac55e69e595765a0 100644
--- a/content/browser/accessibility/browser_accessibility.cc
+++ b/content/browser/accessibility/browser_accessibility.cc
@@ -77,7 +77,7 @@ bool BrowserAccessibility::IsNative() const {
}
bool BrowserAccessibility::IsDescendantOf(
- BrowserAccessibility* ancestor) {
+ const BrowserAccessibility* ancestor) const {
if (this == ancestor) {
return true;
} else if (GetParent()) {
@@ -626,8 +626,8 @@ bool BrowserAccessibility::IsEditableText() const {
}
// Note: WebAXStateReadonly being false means it's either a text control,
- // or contenteditable. We also check for editable text roles to cover
- // another element that has role=textbox set on it.
+ // or contenteditable. We also check for the text field role to cover
+ // elements that have role=textbox set on it.
return (!HasState(ui::AX_STATE_READ_ONLY) ||
GetRole() == ui::AX_ROLE_TEXT_FIELD);
}

Powered by Google App Engine
This is Rietveld 408576698