content/browser/accessibility/browser_accessibility.cc - Issue 1195223006: Reports the position of the caret and current selection in content editables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility.cc

Issue 1195223006: Reports the position of the caret and current selection in content editables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased with master. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility.h ('k') | content/browser/accessibility/browser_accessibility_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility.cc

diff --git a/content/browser/accessibility/browser_accessibility.cc b/content/browser/accessibility/browser_accessibility.cc

index 6b32ef2c9202eff19bd0df8a3f4b177c930f0476..b43f7c5799e23c215273e35c15699be998355591 100644

--- a/content/browser/accessibility/browser_accessibility.cc

+++ b/content/browser/accessibility/browser_accessibility.cc

@@ -79,7 +79,7 @@ bool BrowserAccessibility::IsNative() const {

}

bool BrowserAccessibility::IsDescendantOf(

- BrowserAccessibility* ancestor) {

+ const BrowserAccessibility* ancestor) const {

if (this == ancestor) {

return true;

} else if (GetParent()) {

@@ -621,8 +621,8 @@ bool BrowserAccessibility::IsEditableText() const {

}

// Note: WebAXStateReadonly being false means it's either a text control,

- // or contenteditable. We also check for editable text roles to cover

- // another element that has role=textbox set on it.

+ // or contenteditable. We also check for the text field role to cover

+ // elements that have role=textbox set on it.

return (!HasState(ui::AX_STATE_READ_ONLY) ||

GetRole() == ui::AX_ROLE_TEXT_FIELD);

}