Reports the position of the caret and current selection in content editables.

content/renderer/accessibility/blink_ax_tree_source.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/accessibility/blink_ax_tree_source.h"
 
 #include <set>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 474 matching lines @@
     dst->AddIntAttribute(ui::AX_ATTR_SCROLL_X_MIN, min_offset.width());
     dst->AddIntAttribute(ui::AX_ATTR_SCROLL_Y_MIN, min_offset.height());
 
     const gfx::Size& max_offset = document.maximumScrollOffset();
     dst->AddIntAttribute(ui::AX_ATTR_SCROLL_X_MAX, max_offset.width());
     dst->AddIntAttribute(ui::AX_ATTR_SCROLL_Y_MAX, max_offset.height());
 
     if (node_to_frame_routing_id_map_ && !src.equals(GetRoot())) {
       WebLocalFrame* frame = document.frame();
       RenderFrameImpl* render_frame = RenderFrameImpl::FromWebFrame(frame);
+      RenderFrameProxy* render_frame_proxy = nullptr;
+
       if (render_frame) {
         (*node_to_frame_routing_id_map_)[dst->id] =
             render_frame->GetRoutingID();
-        dst->AddBoolAttribute(ui::AX_ATTR_IS_AX_TREE_HOST, true);
       } else {
-        RenderFrameProxy* render_frame_proxy =
-            RenderFrameProxy::FromWebFrame(frame);
+         render_frame_proxy = RenderFrameProxy::FromWebFrame(frame);
         if (render_frame_proxy) {
           (*node_to_frame_routing_id_map_)[dst->id] =
               render_frame_proxy->routing_id();
-          dst->AddBoolAttribute(ui::AX_ATTR_IS_AX_TREE_HOST, true);
+        }
+      }
+
+      if (render_frame || render_frame_proxy) {
+        dst->AddBoolAttribute(ui::AX_ATTR_IS_AX_TREE_HOST, true);
+
+        WebAXObject anchorObject, focusObject;

[dmazzoni, 2015/06/22 19:23:21]

You don't want this code inside this inner "if" block (if
(node_to_frame_routing_id_map_ && !src.equals(GetRoot())) {) - it's unrelated to
those conditions.

Move it up next to the code like AX_ATTR_DOC_TITLE

+        int anchorOffset, focusOffset;
+        src.selection(anchorObject, anchorOffset, focusObject, focusOffset);
+        if (anchorObject && focusObject &&
+            anchorOffset >= 0 && focusOffset >= 0) {
+          int anchorId = anchorObject.axObjectID();
+          int focusId = focusObject.axObjectID();
+          dst->AddIntAttribute(ui::AX_ATTR_OBJ_SEL_START, anchorId);
+          dst->AddIntAttribute(ui::AX_ATTR_TEXT_SEL_START, anchorOffset);

[dmazzoni, 2015/06/22 19:23:21]

I think it's confusing to reuse TEXT_SEL_START.

Add new attributes that more closely match the blink APIs - like
AX_ATTR_FOCUS_OBJ_ID, AX_ATTR_FOCUS_OFFSET, etc. - and then delete the old
attributes when we no longer need them.

+          dst->AddIntAttribute(ui::AX_ATTR_OBJ_SEL_END, focusId);
+          dst->AddIntAttribute(ui::AX_ATTR_TEXT_SEL_END, focusOffset);
         }
       }
     }
   }
 
   if (dst->role == ui::AX_ROLE_TABLE) {
     int column_count = src.columnCount();
     int row_count = src.rowCount();
     if (column_count > 0 && row_count > 0) {
       std::set<int32> unique_cell_id_set;
@@ skipping 97 matching lines @@
     AddIntListAttributeFromWebObjects(ui::AX_ATTR_OWNS_IDS, owns, dst);
 }
 
 blink::WebDocument BlinkAXTreeSource::GetMainDocument() const {
   if (render_frame_ && render_frame_->GetWebFrame())
     return render_frame_->GetWebFrame()->document();
   return WebDocument();
 }
 
 }  // namespace content