Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: Source/core/editing/SelectionController.h

Issue 1195213002: Clean up the SelectionControl class with c++11 enum class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/editing/SelectionController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/SelectionController.h
diff --git a/Source/core/editing/SelectionController.h b/Source/core/editing/SelectionController.h
index e4649efab71243d72e29f328307cbba570847b91..96f1ed87e1eed91e14d10b6d26bb9b8000d30778 100644
--- a/Source/core/editing/SelectionController.h
+++ b/Source/core/editing/SelectionController.h
@@ -74,7 +74,7 @@ private:
template <typename Strategy>
void updateSelectionForMouseDragAlgorithm(const HitTestResult&, Node*, const LayoutPoint&, const IntPoint&);
- enum AppendTrailingWhitespace { ShouldAppendTrailingWhitespace, DontAppendTrailingWhitespace };
+ enum class AppendTrailingWhitespace { ShouldAppend, DontAppend };
void selectClosestWordFromHitTestResult(const HitTestResult&, AppendTrailingWhitespace);
void selectClosestMisspellingFromHitTestResult(const HitTestResult&, AppendTrailingWhitespace);
void selectClosestWordFromMouseEvent(const MouseEventWithHitTestResults&);
@@ -85,8 +85,8 @@ private:
RawPtrWillBeMember<LocalFrame> const m_frame;
bool m_mouseDownMayStartSelect;
bool m_mouseDownWasSingleClickInSelection;
- enum SelectionInitiationState { HaveNotStartedSelection, PlacedCaret, ExtendedSelection };
- SelectionInitiationState m_selectionInitiationState;
+ enum class SelectionState { HaveNotStartedSelection, PlacedCaret, ExtendedSelection };
+ SelectionState m_selectionState;
};
} // namespace blink
« no previous file with comments | « no previous file | Source/core/editing/SelectionController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698