Clean up the SelectionControl class with c++11 enum class

Clean up the SelectionControl class with c++11 enum class

BUG=483376
TEST=n/a; No behavior changes.
R=yosin@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197719

[Miyoung Shin(g), 2015-06-21 16:06:57]

myid.o.shin@gmail.com changed reviewers:
+ myid.o.shin@gmail.com

[Miyoung Shin(g), 2015-06-21 16:06:57]

yosin@, this is the patch that was supposed to clean up the code at
http://crrev.com/1113323002. PTAL.

[yosin_UTC9, 2015-06-22 02:07:34]

yosin@chromium.org changed reviewers:
- myid.o.shin@gmail.com

[yosin_UTC9, 2015-06-22 02:07:34]

I've changed SelectionController last week, make some functions to be template
functions. 

Please pick these changes up.

[Miyoung Shin(c), 2015-06-22 04:30:44]

On 2015/06/22 02:07:34, Yosi_UTC9 wrote:
> I've changed SelectionController last week, make some functions to be template
> functions. 
> 
> Please pick these changes up.

Done

[yosin_UTC9, 2015-06-22 05:31:11]

Could you do following changes in four patches to minimize diff in each patch?

1 c++11 enum class
2 selection() instead of frame->selection()
3 early return
4 namespace instead of static

Small patches are easy for review.

https://codereview.chromium.org/1195213002/diff/20001/Source/core/editing/Sel...
File Source/core/editing/SelectionController.cpp (right):

https://codereview.chromium.org/1195213002/diff/20001/Source/core/editing/Sel...
Source/core/editing/SelectionController.cpp:93: int textDistance(const Position&
start, const Position& end)
textDistance() is also templatized in ToT. Could you rebase again?

https://codereview.chromium.org/1195213002/diff/20001/Source/core/editing/Sel...
Source/core/editing/SelectionController.cpp:256:
PassOwnPtrWillBeRawPtr<SelectionController>
SelectionController::create(LocalFrame& frame)
Let's keep original source code location for them to minimize patch.

https://codereview.chromium.org/1195213002/diff/20001/Source/core/editing/Sel...
File Source/core/editing/SelectionController.h (right):

https://codereview.chromium.org/1195213002/diff/20001/Source/core/editing/Sel...
Source/core/editing/SelectionController.h:60: void prepareForContextMenu(const
MouseEventWithHitTestResults&, const LayoutPoint&);
I think we don't need to rename this function.

https://codereview.chromium.org/1195213002/diff/20001/Source/core/editing/Sel...
Source/core/editing/SelectionController.h:61: void
preparePassMousePressEventToSubframe(const MouseEventWithHitTestResults&);
I think we don't need to rename this function.

[Miyoung Shin(c), 2015-06-24 07:43:27]

In accordance with your comment, I'd like to put this CL for c++11 enum class
first, and I will try to make the another small patch.

https://codereview.chromium.org/1195213002/diff/20001/Source/core/editing/Sel...
File Source/core/editing/SelectionController.cpp (right):

https://codereview.chromium.org/1195213002/diff/20001/Source/core/editing/Sel...
Source/core/editing/SelectionController.cpp:93: int textDistance(const Position&
start, const Position& end)
On 2015/06/22 05:31:11, Yosi_UTC9 wrote:
> textDistance() is also templatized in ToT. Could you rebase again?

Ok.

https://codereview.chromium.org/1195213002/diff/20001/Source/core/editing/Sel...
Source/core/editing/SelectionController.cpp:256:
PassOwnPtrWillBeRawPtr<SelectionController>
SelectionController::create(LocalFrame& frame)
On 2015/06/22 05:31:10, Yosi_UTC9 wrote:
> Let's keep original source code location for them to minimize patch.

when picking up template codes, it looks like these codes were moved down here.
Where can we locate template codes ?

https://codereview.chromium.org/1195213002/diff/20001/Source/core/editing/Sel...
File Source/core/editing/SelectionController.h (right):

https://codereview.chromium.org/1195213002/diff/20001/Source/core/editing/Sel...
Source/core/editing/SelectionController.h:60: void prepareForContextMenu(const
MouseEventWithHitTestResults&, const LayoutPoint&);
On 2015/06/22 05:31:11, Yosi_UTC9 wrote:
> I think we don't need to rename this function.

OK.

https://codereview.chromium.org/1195213002/diff/20001/Source/core/editing/Sel...
Source/core/editing/SelectionController.h:61: void
preparePassMousePressEventToSubframe(const MouseEventWithHitTestResults&);
On 2015/06/22 05:31:11, Yosi_UTC9 wrote:
> I think we don't need to rename this function.

OK

[yosin_UTC9, 2015-06-24 07:50:18]

lgtm

Thanks!! (^_^)b

[yosin_UTC9, 2015-06-24 07:50:22]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-06-24 07:50:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1195213002/40001

[commit-bot: I haz the power, 2015-06-24 09:26:05]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197719