Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1195163002: Revert of Ship Harmony Array/TypedArray methods (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Ship Harmony Array/TypedArray methods (patchset #6 id:100001 of https://codereview.chromium.org/1187543003/) Reason for revert: [Sheriff] Breaks gcstress and mac asan: http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%203/builds/3896 http://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/1774 Original issue's description: > Ship Harmony Array/TypedArray methods > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > BUG=v8:3578 > LOG=Y > R=adamk > > Committed: https://crrev.com/7142b0d211b732e1c119fded80f43fbbd9cea0f8 > Cr-Commit-Position: refs/heads/master@{#29170} TBR=adamk@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3578 Committed: https://crrev.com/a002cbd7436cda87e53f4c9a827cf007615b2e06 Cr-Commit-Position: refs/heads/master@{#29171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-1132.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Ship Harmony Array/TypedArray methods
5 years, 6 months ago (2015-06-20 07:25:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195163002/1
5 years, 6 months ago (2015-06-20 07:25:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-20 07:25:25 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-20 07:25:36 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a002cbd7436cda87e53f4c9a827cf007615b2e06
Cr-Commit-Position: refs/heads/master@{#29171}

Powered by Google App Engine
This is Rietveld 408576698