Issue 1195113002: Improve stocks2 performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1195113002: Improve stocks2 performance (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Improve stocks2 performance We're now 25% faster as scrolling the infinite list than stocks1. This CL makes cleans up some code to avoid calling layout on all the rows in the stocks list. Instead, we only layout a row when it first enters the list. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/de59adc95cf2433d66aaa1e13bdd7b7f6ada2e78

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+110 lines, -30 lines)			Patch
M	sky/sdk/lib/painting/text_style.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/rendering/block.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sky/sdk/lib/rendering/box.dart	View	4 chunks	+32 lines, -8 lines	0 comments	Download
M	sky/sdk/lib/rendering/object.dart	View	4 chunks	+37 lines, -15 lines	0 comments	Download
M	sky/sdk/lib/rendering/paragraph.dart	View	3 chunks	+27 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/widgets/widget.dart	View	6 chunks	+10 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 6 months ago (2015-06-19 22:44:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
de59adc95cf2433d66aaa1e13bdd7b7f6ada2e78 (presubmit successful).