Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1195113002: Improve stocks2 performance (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Improve stocks2 performance We're now 25% faster as scrolling the infinite list than stocks1. This CL makes cleans up some code to avoid calling layout on all the rows in the stocks list. Instead, we only layout a row when it first enters the list. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/de59adc95cf2433d66aaa1e13bdd7b7f6ada2e78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -30 lines) Patch
M sky/sdk/lib/painting/text_style.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/sdk/lib/rendering/block.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sky/sdk/lib/rendering/box.dart View 4 chunks +32 lines, -8 lines 0 comments Download
M sky/sdk/lib/rendering/object.dart View 4 chunks +37 lines, -15 lines 0 comments Download
M sky/sdk/lib/rendering/paragraph.dart View 3 chunks +27 lines, -0 lines 0 comments Download
M sky/sdk/lib/widgets/widget.dart View 6 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-19 22:36:00 UTC) #1
Hixie
lgtm
5 years, 6 months ago (2015-06-19 22:43:45 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-06-19 22:44:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
de59adc95cf2433d66aaa1e13bdd7b7f6ada2e78 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698