Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1195003003: Propagate SkSurfaceProps to more call sites (Closed)

Created:
5 years, 6 months ago by robertphillips
Modified:
5 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Propagate SkSurfaceProps to more call sites Start moving to a world where everyone provides surface properties. Most notably this exposes a portion of SkSurfaceProps to the C API. BUG=skia:3934 Committed: https://skia.googlesource.com/skia/+/702edbd4bc41230902b5fe69d14d15763c27fafe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -15 lines) Patch
M example/HelloWorld.h View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/cgm.c View 1 chunk +2 lines, -1 line 0 comments Download
M include/c/sk_surface.h View 1 chunk +3 lines, -2 lines 0 comments Download
M include/c/sk_types.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/c/sk_surface.cpp View 3 chunks +46 lines, -5 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkLua.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/CTest.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M tools/skhello.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
robertphillips
5 years, 6 months ago (2015-06-22 21:11:09 UTC) #2
reed1
lgtm
5 years, 6 months ago (2015-06-22 22:59:01 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195003003/1
5 years, 6 months ago (2015-06-23 12:32:49 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-23 12:38:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195003003/1
5 years, 6 months ago (2015-06-23 13:25:38 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 13:26:11 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/702edbd4bc41230902b5fe69d14d15763c27fafe

Powered by Google App Engine
This is Rietveld 408576698