mojo/application/public/cpp/lib/application_runner.cc - Issue 1195003002: Mandoline: Introduce ApplicationConnection::CloseConnection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/application/public/cpp/lib/application_runner.cc

Issue 1195003002: Mandoline: Introduce ApplicationConnection::CloseConnection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed typo Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/application/public/cpp/lib/application_impl.cc ('K') | « mojo/application/public/cpp/lib/application_impl.cc ('k') | mojo/application/public/cpp/lib/service_registry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/application/public/cpp/lib/application_runner.cc

diff --git a/mojo/application/public/cpp/lib/application_runner.cc b/mojo/application/public/cpp/lib/application_runner.cc

index cacead23697f79688573acad0cccc78345b8d5ef..19c38793d05f5472f8d95c49d4603e13a44b770d 100644

--- a/mojo/application/public/cpp/lib/application_runner.cc

+++ b/mojo/application/public/cpp/lib/application_runner.cc

@@ -68,6 +68,9 @@ MojoResult ApplicationRunner::Run(MojoHandle application_request_handle,

// connection error handlers and they might access objects created by the

// delegate.

loop.reset();

+ // Give |impl| an opportunity to perform some cleanup prior to destruction

+ // of the delegate.

+ impl.WillDestroySoon();

delegate_.reset();

}

return MOJO_RESULT_OK;