Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: mojo/application/public/cpp/lib/application_connection.cc

Issue 1195003002: Mandoline: Introduce ApplicationConnection::CloseConnection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/application/public/cpp/lib/application_connection.cc
diff --git a/mojo/application/public/cpp/lib/application_connection.cc b/mojo/application/public/cpp/lib/application_connection.cc
index a76757f552bbb0b288f565af06644fe9a7d41f6d..c286c85987228681df09df34c42f733c4de45bcc 100644
--- a/mojo/application/public/cpp/lib/application_connection.cc
+++ b/mojo/application/public/cpp/lib/application_connection.cc
@@ -4,9 +4,25 @@
#include "mojo/application/public/cpp/application_connection.h"
+#include "base/logging.h"
+
namespace mojo {
+ApplicationConnection::ApplicationConnection() : connection_closed_(false) {
+}
+
+void ApplicationConnection::CloseConnection() {
+ if (connection_closed_)
+ return;
+ OnCloseConnection();
+ connection_closed_ = true;
+ delete this;
+}
+
ApplicationConnection::~ApplicationConnection() {
+ // If this DCHECK fails then something has tried to delete this object without
+ // calling CloseConnection.
+ DCHECK(connection_closed_);
}
} // namespace mojo

Powered by Google App Engine
This is Rietveld 408576698