Mandoline: Introduce ApplicationConnection::CloseConnection

mojo/application/public/cpp/lib/application_impl.cc

Index: mojo/application/public/cpp/lib/application_impl.cc
diff --git a/mojo/application/public/cpp/lib/application_impl.cc b/mojo/application/public/cpp/lib/application_impl.cc
index bafabe276fbc04eb61da9300ebc3412fbd1577e8..3b131eafc35b757df913ce2a53bb9ebaf307325c 100644
--- a/mojo/application/public/cpp/lib/application_impl.cc
+++ b/mojo/application/public/cpp/lib/application_impl.cc
@@ -4,6 +4,8 @@
 
 #include "mojo/application/public/cpp/application_impl.h"
 
+#include <algorithm>
+
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "mojo/application/public/cpp/application_delegate.h"
@@ -77,6 +79,15 @@ ApplicationConnection* ApplicationImpl::ConnectToApplication(
   return registry;
 }
 
+void ApplicationImpl::CloseConnection(ApplicationConnection* connection) {
+  auto it = std::find(outgoing_service_registries_.begin(),
+                      outgoing_service_registries_.end(),
+                      connection);
+  DCHECK(it != outgoing_service_registries_.end());
+  delete *it;

[sky, 2015/06/19 19:22:19]

IMO I would erase first, then delete. That way you don't have to worry about
side effects to the underlying vector.

[Fady Samuel, 2015/06/26 22:41:20]

Done.

+  outgoing_service_registries_.erase(it);

[sky, 2015/06/19 19:22:19]

Can't this be used for incoming connections too?

[Fady Samuel, 2015/06/26 22:41:20]

Done.

+}
+
 void ApplicationImpl::Initialize(ShellPtr shell, const mojo::String& url) {
   shell_ = shell.Pass();
   shell_.set_error_handler(this);