Mandoline: Introduce ApplicationConnection::CloseConnection

mandoline/ui/browser/browser_apptest.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "mandoline/ui/browser/browser.h"

[sky, 2015/06/29 16:56:02]

nit: newline after this line.

[Fady Samuel, 2015/06/29 20:32:36]

Done.

+#include "mandoline/ui/browser/browser_delegate.h"
+#include "mojo/application/public/cpp/application_connection.h"
+#include "mojo/application/public/cpp/application_delegate.h"
+#include "mojo/application/public/cpp/application_impl.h"
+#include "mojo/application/public/cpp/application_test_base.h"
+
+namespace mandoline {
+
+class BrowserTest : public mojo::test::ApplicationTestBase,
+                    public mojo::ApplicationDelegate,
+                    public BrowserDelegate {
+ public:
+  BrowserTest() : app_(nullptr), last_closed_connection_(nullptr) {}
+
+  // Creates a new Browser object.
+  Browser* CreateBrowser() {
+    DCHECK(app_);

[sky, 2015/06/29 16:56:02]

If you can, avoid DCHECKs in tests. They trigger a crash of the whole harness.
Instead use ASSERT/EXPECT/FAIL... In this particular case I would early return
nullptr, the call site ASSERTs on the return value, so that should be fine.

[Fady Samuel, 2015/06/29 20:32:36]

Done.

+    Browser* browser = new Browser(app_, this);
+    browsers_.insert(browser);
+    return browser;
+  }
+
+  // Returns the last ApplicationConnection closed.
+  mojo::ApplicationConnection* last_closed_connection() {
+    return last_closed_connection_;
+  }
+
+  // Overridden from ApplicationDelegate:
+  void Initialize(mojo::ApplicationImpl* app) override {
+    app_ = app;
+  }
+
+  void OnWillCloseConnection(mojo::ApplicationConnection* connection) override {
+    // WARNING: DO NOT FOLLOW THIS POINTER. IT WILL BE DESTROYED.
+    last_closed_connection_ = connection;
+  }
+
+  // ApplicationTestBase:
+  ApplicationDelegate* GetApplicationDelegate() override { return this; }
+
+  // Overridden from BrowserDelegate:
+  void BrowserClosed(Browser* browser) override {
+    scoped_ptr<Browser> browser_owner(browser);
+    DCHECK_GT(browsers_.count(browser), 0u);
+    browsers_.erase(browser);
+  }
+
+  bool InitUIIfNecessary(Browser* browser, mojo::View* root_view) override {
+    return true;
+  }
+
+ private:
+  mojo::ApplicationImpl* app_;
+  mojo::ApplicationConnection* last_closed_connection_;
+  std::set<Browser*> browsers_;
+
+  MOJO_DISALLOW_COPY_AND_ASSIGN(BrowserTest);
+};
+
+// This test verifies that closing a Browser closes the associated application
+// connection with the view manager.
+TEST_F(BrowserTest, ClosingBrowserClosesAppConnetion) {
+  Browser* browser = CreateBrowser();
+  ASSERT_NE(nullptr, browser);
+  mojo::ApplicationConnection* view_manager_connection =
+      browser->GetViewManagerConnectionForTesting();
+  ASSERT_NE(nullptr, view_manager_connection);
+  BrowserClosed(browser);
+  EXPECT_EQ(last_closed_connection(), view_manager_connection);
+}
+
+}  // namespace mandoline