Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: runtime/vm/flow_graph_optimizer.cc

Issue 1194963004: Fix bingint crash, disable a test (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph_optimizer.h" 5 #include "vm/flow_graph_optimizer.h"
6 6
7 #include "vm/bit_vector.h" 7 #include "vm/bit_vector.h"
8 #include "vm/cha.h" 8 #include "vm/cha.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 } 155 }
156 156
157 157
158 // TODO(srdjan): Test/support other number types as well. 158 // TODO(srdjan): Test/support other number types as well.
159 static bool IsNumberCid(intptr_t cid) { 159 static bool IsNumberCid(intptr_t cid) {
160 return (cid == kSmiCid) || (cid == kDoubleCid); 160 return (cid == kSmiCid) || (cid == kDoubleCid);
161 } 161 }
162 162
163 163
164 bool FlowGraphOptimizer::TryCreateICData(InstanceCallInstr* call) { 164 bool FlowGraphOptimizer::TryCreateICData(InstanceCallInstr* call) {
165 return false;
166 // TODO(srdjan): Investigate failures in:
167 // corelib/big_integer_arith_vm_test
168 // dart2js/members_test
169 // language/try_catch_optimized1_test
165 ASSERT(call->HasICData()); 170 ASSERT(call->HasICData());
166 if (call->ic_data()->NumberOfUsedChecks() > 0) { 171 if (call->ic_data()->NumberOfUsedChecks() > 0) {
167 // This occurs when an instance call has too many checks, will be converted 172 // This occurs when an instance call has too many checks, will be converted
168 // to megamorphic call. 173 // to megamorphic call.
169 return false; 174 return false;
170 } 175 }
171 if (FLAG_warn_on_javascript_compatibility) { 176 if (FLAG_warn_on_javascript_compatibility) {
172 // Do not make the instance call megamorphic if the callee needs to decode 177 // Do not make the instance call megamorphic if the callee needs to decode
173 // the calling code sequence to lookup the ic data and verify if a warning 178 // the calling code sequence to lookup the ic data and verify if a warning
174 // has already been issued or not. 179 // has already been issued or not.
(...skipping 8523 matching lines...) Expand 10 before | Expand all | Expand 10 after
8698 8703
8699 // Insert materializations at environment uses. 8704 // Insert materializations at environment uses.
8700 for (intptr_t i = 0; i < exits_collector_.exits().length(); i++) { 8705 for (intptr_t i = 0; i < exits_collector_.exits().length(); i++) {
8701 CreateMaterializationAt( 8706 CreateMaterializationAt(
8702 exits_collector_.exits()[i], alloc, *slots); 8707 exits_collector_.exits()[i], alloc, *slots);
8703 } 8708 }
8704 } 8709 }
8705 8710
8706 8711
8707 } // namespace dart 8712 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698